Issue 5763 - Target languages supported by Firefox

build.py

Index: build.py
===================================================================
--- a/build.py
+++ b/build.py
@@ -252,7 +252,6 @@
         localeConfig = {
             'name_format': 'BCP-47',
             'file_format': 'gecko-dtd',
-            'target_platforms': {'gecko'},
             'default_locale': packager.defaultLocale
         }
     elif type in {'chrome', 'gecko-webext'}:
@@ -261,7 +260,6 @@
         localeConfig = {
             'name_format': 'ISO-15897',
             'file_format': 'chrome-json',
-            'target_platforms': {'chrome'},
             'default_locale': packager.defaultLocale,
         }
     else:
@@ -271,8 +269,6 @@
         localeConfig = {
             'name_format': metadata.get('locales', 'name_format'),
             'file_format': metadata.get('locales', 'file_format'),
-            'target_platforms': set(metadata.get('locales',
-                                                 'target_platforms').split()),
             'default_locale': metadata.get('locales', 'default_locale')
         }
 
@@ -344,7 +340,7 @@
 
     import buildtools.localeTools as localeTools
     for locale, localeDir in localeConfig['locales'].iteritems():
-        if locale != localeConfig['default_locale']:
+        if locale != localeConfig['default_locale'].replace('_', '-'):

[Sebastian Noack, 2017/10/04 21:33:51]

uploadtrans was failing because en-US doesn't exist as a target language. Note
that before setuptrans also mistakenly added the source/default language as a
target language, so if you did run setuptrans+translate+uploadtrans before, this
error wouldn't occur.

But the actual bug here isn't new, which is that "default_locale" uses either
underscores or dashes based on the format used, while "locales" has been already
normalized to use dashes. So the check here never worked for the ISO format.

             localeTools.uploadTranslations(localeConfig, metadata, localeDir, locale,
                                            basename, key)