Issue 5751 - Removing legacy gecko support

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import sys
 import re
 import subprocess
 import shutil
-import buildtools
 from getopt import getopt, GetoptError
 from StringIO import StringIO
 from zipfile import ZipFile
 
 knownTypes = ('gecko-webext', 'chrome', 'safari', 'generic', 'edge')
 
 
 class Command(object):
     name = property(lambda self: self._name)
     shortDescription = property(
@@ skipping 191 matching lines @@
     devenv_dir = getDevEnvPath(baseDir, type)
 
     shutil.rmtree(devenv_dir, ignore_errors=True)
 
     file.seek(0)
     with ZipFile(file, 'r') as zip_file:
         zip_file.extractall(devenv_dir)
 
 
 def readLocaleConfig(baseDir, type, metadata):
-    if type in {'chrome', 'gecko-webext'}:

[Sebastian Noack, 2017/10/04 22:33:00]

I think we can make all the translation commands (i.e.
setuptrans/translate/uploadtrans/gettranslations) agnostic of the release
target, now. All it seems to take would be changing the check here to `type !=
'generic'` and remove the `supportedTypes` property from these commands.

[tlucas, 2017/10/05 10:10:30]

Good idea, would clean things up a bit more. Done.

+    if type != 'generic':

[Vasily Kuznetsov, 2017/10/10 12:44:33]

We could swap the branches of this if statement to get a more natural looking:

    if type == 'generic':
        ...
    else:
        ...

[tlucas, 2017/10/10 12:50:13]

Well, imho the "not generic" platforms are those most interesting to us - so the
order is quite natural i'd say ;)

         import buildtools.packagerChrome as packager
         localeDir = os.path.join(baseDir, '_locales')
         localeConfig = {
             'default_locale': packager.defaultLocale,
         }
     else:
         localeDir = os.path.join(
             baseDir, *metadata.get('locales', 'base_path').split('/')
         )
         localeConfig = {
@@ skipping 58 matching lines @@
     key = args[0]
 
     from buildtools.packager import readMetadata
     metadata = readMetadata(baseDir, type)
 
     basename = metadata.get('general', 'basename')
     localeConfig = readLocaleConfig(baseDir, type, metadata)
 
     import buildtools.localeTools as localeTools
     for locale, localeDir in localeConfig['locales'].iteritems():
-        if locale != localeConfig['default_locale']:
+        if locale != localeConfig['default_locale'].replace('_', '-'):
             localeTools.uploadTranslations(localeConfig, metadata, localeDir, locale,
                                            basename, key)
 
 
 def getTranslations(baseDir, scriptName, opts, args, type):
     if len(args) < 1:
         print 'Project key is required to update translation master files.'
         usage(scriptName, type, 'translate')
         return
 
@@ skipping 65 matching lines @@
         return
 
     import buildtools.releaseAutomation as releaseAutomation
     releaseAutomation.run(baseDir, type, version, keyFile, downloadsRepo)
 
 
 def updatePSL(baseDir, scriptName, opts, args, type):
     import buildtools.publicSuffixListUpdater as publicSuffixListUpdater
     publicSuffixListUpdater.updatePSL(baseDir)
 
+
 with addCommand(lambda baseDir, scriptName, opts, args, type: usage(scriptName, type), ('help', '-h', '--help')) as command:
     command.shortDescription = 'Show this message'
 
 with addCommand(runBuild, 'build') as command:
     command.shortDescription = 'Create a build'
     command.description = 'Creates an extension build with given file name. If output_file is missing a default name will be chosen.'
     command.params = '[options] [output_file]'
     command.addOption('Use given build number (if omitted the build number will be retrieved from Mercurial)', short='b', long='build', value='num')
     command.addOption('File containing private key and certificates required to sign the package', short='k', long='key', value='file', types=('chrome', 'safari'))
     command.addOption('Create a release build', short='r', long='release')
     command.supportedTypes = ('gecko-webext', 'chrome', 'safari', 'edge')
 
 with addCommand(createDevEnv, 'devenv') as command:
     command.shortDescription = 'Set up a development environment'
     command.description = 'Will set up or update the devenv folder as an unpacked extension folder for development.'
     command.supportedTypes = ('gecko-webext', 'chrome', 'safari')
 
 with addCommand(setupTranslations, 'setuptrans') as command:
     command.shortDescription = 'Sets up translation languages'
     command.description = 'Sets up translation languages for the project on crowdin.net.'
     command.params = '[options] project-key'
-    command.supportedTypes = ('chrome', 'generic')
 
 with addCommand(updateTranslationMaster, 'translate') as command:
     command.shortDescription = 'Updates translation master files'
     command.description = 'Updates the translation master files in the project on crowdin.net.'
     command.params = '[options] project-key'
-    command.supportedTypes = ('chrome', 'generic')
 
 with addCommand(uploadTranslations, 'uploadtrans') as command:
     command.shortDescription = 'Uploads existing translations'
     command.description = 'Uploads already existing translations to the project on crowdin.net.'
     command.params = '[options] project-key'
-    command.supportedTypes = ('chrome', 'generic')
 
 with addCommand(getTranslations, 'gettranslations') as command:
     command.shortDescription = 'Downloads translation updates'
     command.description = 'Downloads updated translations from crowdin.net.'
     command.params = '[options] project-key'
-    command.supportedTypes = ('chrome', 'generic')
 
 with addCommand(generateDocs, 'docs') as command:
     command.shortDescription = 'Generate documentation (requires node.js)'
     command.description = ('Generate documentation files and write them into '
                            'the specified directory.')
     command.addOption('Suppress JsDoc output', short='q', long='quiet')
     command.params = '[options] <directory>'
-    command.supportedTypes = ('chrome')
+    command.supportedTypes = ('chrome',)
 
 with addCommand(runReleaseAutomation, 'release') as command:
     command.shortDescription = 'Run release automation'
     command.description = 'Note: If you are not the project owner then you '        "probably don't want to run this!\n\n"        'Runs release automation: creates downloads for the new version, tags '        'source code repository as well as downloads and buildtools repository.'
     command.addOption('File containing private key and certificates required to sign the release.', short='k', long='key', value='file', types=('chrome', 'safari', 'edge'))
     command.addOption('Directory containing downloads repository (if omitted ../downloads is assumed)', short='d', long='downloads', value='dir')
     command.params = '[options] <version>'
     command.supportedTypes = ('chrome', 'safari', 'edge')
 
 with addCommand(updatePSL, 'updatepsl') as command:
@@ skipping 67 matching lines @@
                 if option in ('-h', '--help'):
                     usage(scriptName, type, command)
                     sys.exit()
             commands[command](baseDir, scriptName, opts, args, type)
         else:
             print 'Command %s is not supported for this application type' % command
             usage(scriptName, type)
     else:
         print 'Command %s is unrecognized' % command
         usage(scriptName, type)