Issue 5751 - Removing legacy gecko support

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import sys
 import re
 import subprocess
 import shutil
 from getopt import getopt, GetoptError
@@ skipping 200 matching lines @@
     devenv_dir = getDevEnvPath(baseDir, type)
 
     shutil.rmtree(devenv_dir, ignore_errors=True)
 
     file.seek(0)
     with ZipFile(file, 'r') as zip_file:
         zip_file.extractall(devenv_dir)
 
 
 def readLocaleConfig(baseDir, type, metadata):
     if type != 'generic':

[Vasily Kuznetsov, 2017/10/10 12:44:33]

We could swap the branches of this if statement to get a more natural looking:

    if type == 'generic':
        ...
    else:
        ...

[tlucas, 2017/10/10 12:50:13]

Well, imho the "not generic" platforms are those most interesting to us - so the
order is quite natural i'd say ;)

         import buildtools.packagerChrome as packager
         localeDir = os.path.join(baseDir, '_locales')
         localeConfig = {
             'default_locale': packager.defaultLocale,
         }
     else:
         localeDir = os.path.join(
             baseDir, *metadata.get('locales', 'base_path').split('/')
         )
         localeConfig = {
@@ skipping 144 matching lines @@
         return
 
     import buildtools.releaseAutomation as releaseAutomation
     releaseAutomation.run(baseDir, type, version, keyFile, downloadsRepo)
 
 
 def updatePSL(baseDir, scriptName, opts, args, type):
     import buildtools.publicSuffixListUpdater as publicSuffixListUpdater
     publicSuffixListUpdater.updatePSL(baseDir)
 
 

[tlucas, 2017/10/06 09:06:49]

This line would have been the only one to have to ignore an E305.

 with addCommand(lambda baseDir, scriptName, opts, args, type: usage(scriptName, type), ('help', '-h', '--help')) as command:
     command.shortDescription = 'Show this message'
 
 with addCommand(runBuild, 'build') as command:
     command.shortDescription = 'Create a build'
     command.description = 'Creates an extension build with given file name. If output_file is missing a default name will be chosen.'
     command.params = '[options] [output_file]'
     command.addOption('Use given build number (if omitted the build number will be retrieved from Mercurial)', short='b', long='build', value='num')
     command.addOption('File containing private key and certificates required to sign the package', short='k', long='key', value='file', types=('chrome', 'safari'))
     command.addOption('Create a release build', short='r', long='release')
@@ skipping 111 matching lines @@
                 if option in ('-h', '--help'):
                     usage(scriptName, type, command)
                     sys.exit()
             commands[command](baseDir, scriptName, opts, args, type)
         else:
             print 'Command %s is not supported for this application type' % command
             usage(scriptName, type)
     else:
         print 'Command %s is unrecognized' % command
         usage(scriptName, type)