Issue 5751 - Removing legacy gecko support

packagerChrome.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import errno
 import io
 import json
 import os
 import re
 from StringIO import StringIO
@@ skipping 178 matching lines @@
         data, ensure_ascii=False, sort_keys=True,
         indent=2, separators=(',', ': ')
     ).encode('utf-8') + '\n'
 
 
 def import_locales(params, files):
     for item in params['metadata'].items('import_locales'):
         filename, keys = item
         for sourceFile in glob.glob(os.path.join(os.path.dirname(item.source),
                                                  *filename.split('/'))):
-            locale = sourceFile.split(os.path.sep)[-2].replace('-', '_')

[Sebastian Noack, 2017/10/06 19:13:28]

As pointed out on the review introducing this code, replacing dashes with
underscores are no longer necessary, once all paths are assumed to use ISO
format (i.e. underscored) for language codes.

[tlucas, 2017/10/09 23:18:07]

Done.

+            locale = sourceFile.split(os.path.sep)[-2]
             targetFile = os.path.join('_locales', locale, 'messages.json')
             data = json.loads(files.get(targetFile, '{}').decode('utf-8'))
 
             try:
                 with io.open(sourceFile, 'r', encoding='utf-8') as handle:
                     sourceData = json.load(handle)
 
                 # Resolve wildcard imports
-                if keys == '*' or keys == '=*':
+                if keys == '*':
                     importList = sourceData.keys()
                     importList = filter(lambda k: not k.startswith('_'), importList)
-                    if keys == '=*':
-                        importList = map(lambda k: '=' + k, importList)
                     keys = ' '.join(importList)
 
                 for stringID in keys.split():
-                    noMangling = False
-                    if stringID.startswith('='):
-                        stringID = stringID[1:]
-
                     if stringID in sourceData:
-                        key = re.sub(r'\W', '_', stringID)

[Sebastian Noack, 2017/10/06 19:13:29]

This should no longer be necessary either, as we will only import strings that
are already in the same format, now.

[tlucas, 2017/10/09 23:18:07]

A quick test verified your assumption, this line has no effect for all targets -
removed it.

-                        if key in data:
-                            print 'Warning: locale string %s defined multiple times' % key
-
-                        data[key] = sourceData[stringID]
+                        if stringID in data:
+                            print ('Warning: locale string {} defined multiple'
+                                   ' times').format(stringID)
+
+                        data[stringID] = sourceData[stringID]
             except Exception as e:
                 print 'Warning: error importing locale data from %s: %s' % (sourceFile, e)
 
             files[targetFile] = toJson(data)
 
 
 def truncate(text, length_limit):
     if len(text) <= length_limit:
         return text
     return text[:length_limit - 1].rstrip() + u'\u2026'
@@ skipping 129 matching lines @@
                 params, 'testIndex.html.tmpl', ('general', 'testScripts')
             )
 
     zipdata = files.zipToString()
     signature = None
     pubkey = None
     if keyFile != None:
         signature = signBinary(zipdata, keyFile)
         pubkey = getPublicKey(keyFile)
     writePackage(outFile, pubkey, signature, zipdata)