Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: releaseAutomation.py

Issue 29562614: Issue 5752 - Removing safari support (Closed)
Patch Set: Addressing comment Created Oct. 6, 2017, 9:18 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packagerSafari.py ('k') | templates/Info.plist.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: releaseAutomation.py
diff --git a/releaseAutomation.py b/releaseAutomation.py
index a7c09aa7782cd20d3139a678ffc971cc0ed00c8e..805fa257c92f49f52317a82b4725c8a3205e2632 100644
--- a/releaseAutomation.py
+++ b/releaseAutomation.py
@@ -118,9 +118,7 @@ def run(baseDir, type, version, keyFile, downloadsRepo):
print('Aborting release.')
return 1
- if type == 'safari':
- import buildtools.packagerSafari as packager
- elif type == 'edge':
+ if type == 'edge':
import buildtools.packagerEdge as packager
elif type == 'chrome':
import buildtools.packagerChrome as packager
@@ -148,7 +146,7 @@ def run(baseDir, type, version, keyFile, downloadsRepo):
# Now commit the change and tag it
subprocess.check_call(['hg', 'commit', '-R', baseDir, '-m', 'Releasing %s %s' % (extensionName, version)])
tag_name = version
- if type in {'safari', 'edge'}:
+ if type == 'edge':
tag_name = '{}-{}'.format(tag_name, type)
subprocess.check_call(['hg', 'tag', '-R', baseDir, '-f', tag_name])
@@ -162,10 +160,6 @@ def run(baseDir, type, version, keyFile, downloadsRepo):
buildPathUnsigned = os.path.join(baseDir, getDefaultFileName(metadata, version, 'zip'))
packager.createBuild(baseDir, type=type, outFile=buildPathUnsigned, releaseBuild=True, keyFile=None)
- elif type == 'safari':
- buildPath = os.path.join(downloadsRepo, getDefaultFileName(metadata, version, 'safariextz'))
- packager.createBuild(baseDir, type='safari', outFile=buildPath, releaseBuild=True, keyFile=keyFile)
- downloads.append(buildPath)
elif type == 'edge':
# We only offer the Edge extension for use through the Windows Store
buildPath = os.path.join(downloadsRepo, getDefaultFileName(metadata, version, 'appx'))
« no previous file with comments | « packagerSafari.py ('k') | templates/Info.plist.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld