Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29564555: Issue 5824 - Refactor CustomSelect on help.eyeo.com (Closed)

Created:
Oct. 4, 2017, 8:05 a.m. by ire
Modified:
Oct. 10, 2017, 11:55 a.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 5824 - Refactor CustomSelect on help.eyeo.com

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update comment style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -19 lines) Patch
M includes/layout/footer.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M static/js/main.js View 1 2 chunks +50 lines, -18 lines 0 comments Download

Messages

Total messages: 4
ire
Oct. 4, 2017, 8:06 a.m. (2017-10-04 08:06:03 UTC) #1
ire
Ready for review https://codereview.adblockplus.org/29564555/diff/29564556/static/js/main.js File static/js/main.js (right): https://codereview.adblockplus.org/29564555/diff/29564556/static/js/main.js#newcode5 static/js/main.js:5: /* ****************************************** The document was starting ...
Oct. 4, 2017, 8:07 a.m. (2017-10-04 08:07:41 UTC) #2
juliandoucette
LGTM https://codereview.adblockplus.org/29564555/diff/29564556/static/js/main.js File static/js/main.js (right): https://codereview.adblockplus.org/29564555/diff/29564556/static/js/main.js#newcode5 static/js/main.js:5: /* ****************************************** On 2017/10/04 08:07:40, ire wrote: > ...
Oct. 9, 2017, 11:14 p.m. (2017-10-09 23:14:15 UTC) #3
ire
Oct. 10, 2017, 11:54 a.m. (2017-10-10 11:54:18 UTC) #4
https://codereview.adblockplus.org/29564555/diff/29564556/static/js/main.js
File static/js/main.js (right):

https://codereview.adblockplus.org/29564555/diff/29564556/static/js/main.js#n...
static/js/main.js:5: /* ******************************************
On 2017/10/09 23:14:15, juliandoucette wrote:
> On 2017/10/04 08:07:40, ire wrote:
> > The document was starting to get really long so I added these comments
> 
> Acknowledged.
> 
> We should be consistent about how we format these comments. I don't like those
> [extra spaces, extra lines, not 79 or 80 char lines]. If you do, then we could
> come up with some interesting way of deciding e.g. bet or game.

I think I actually prefer your way so updating that now. 

We'll have to find something else to bet on :p

Powered by Google App Engine
This is Rietveld