Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29565558: Issue 5814 - Import translations for new strings (Closed)

Created:
Oct. 5, 2017, 9:36 a.m. by jens
Modified:
Oct. 6, 2017, noon
Reviewers:
anton, diegocarloslima
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5814 - Import translations for new strings

Patch Set 1 : Issue 5814 - Import translations for new strings #

Total comments: 1

Patch Set 2 : Use Cologne and Germany for all languages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M adblockplussbrowser/res/values-de/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-el/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-es/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-fr/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-it/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-ko/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-nl/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-pl/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-pt/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-ru/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M adblockplussbrowser/res/values-tr/strings.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jens
Oct. 5, 2017, 12:47 p.m. (2017-10-05 12:47:08 UTC) #1
diegocarloslima
On 2017/10/05 12:47:08, jens wrote: LGTM
Oct. 5, 2017, 1:57 p.m. (2017-10-05 13:57:05 UTC) #2
anton
https://codereview.adblockplus.org/29565558/diff/29565633/adblockplussbrowser/res/values-ru/strings.xml File adblockplussbrowser/res/values-ru/strings.xml (right): https://codereview.adblockplus.org/29565558/diff/29565633/adblockplussbrowser/res/values-ru/strings.xml#newcode50 adblockplussbrowser/res/values-ru/strings.xml:50: <string name="imprint_text"><![CDATA[<p><b><font color=\"#ffffff\">eyeo GmbH</font></b> <br/>Lichtstraße 25 <br/>50825 Cologne <br/>Германия</p> ...
Oct. 5, 2017, 2:21 p.m. (2017-10-05 14:21:18 UTC) #3
jens
On 2017/10/05 14:21:18, anton wrote: > https://codereview.adblockplus.org/29565558/diff/29565633/adblockplussbrowser/res/values-ru/strings.xml > File adblockplussbrowser/res/values-ru/strings.xml (right): > > https://codereview.adblockplus.org/29565558/diff/29565633/adblockplussbrowser/res/values-ru/strings.xml#newcode50 > ...
Oct. 5, 2017, 2:48 p.m. (2017-10-05 14:48:52 UTC) #4
anton
Oct. 6, 2017, 8:52 a.m. (2017-10-06 08:52:46 UTC) #5
On 2017/10/05 14:48:52, jens wrote:
> On 2017/10/05 14:21:18, anton wrote:
> >
>
https://codereview.adblockplus.org/29565558/diff/29565633/adblockplussbrowser...
> > File adblockplussbrowser/res/values-ru/strings.xml (right):
> > 
> >
>
https://codereview.adblockplus.org/29565558/diff/29565633/adblockplussbrowser...
> > adblockplussbrowser/res/values-ru/strings.xml:50: <string
> > name="imprint_text"><![CDATA[<p><b><font color=\"#ffffff\">eyeo
> GmbH</font></b>
> > <br/>Lichtstraße 25 <br/>50825 Cologne <br/>Германия</p> <p>Поддержка:
<br/><a
> > href=\"https://adblockplus.org/forum/\">Adblock Plus Forum</a> <br/>Эл.
> > почта:<br/><a href=\"mailto:info@eyeo.com\">info@eyeo.com</a>
> > <br/>Телефон:<br/>+49 (0)221 / 65028 598 <br/>Факс:<br/>+49 (0)221 / 65028
> > 599</p> <p>НДС №:<br/>DE279292414 <br/>Федеральный суд Кельна: <br/>HRB
> > 73508</p> <p><b><font color=\"#ffffff\">Директора</font></b>: <br/>Till
Faida
> > <br/>Felix Dahlke <br/>Steffen Kiedel</p>]]></string>
> > "Cologne" is not translated into Russian "Кельн". Is it intentionally?
Germany
> > is translated so i expected both to be translated or both not..
> 
> Thanks anton, I'll forward this question to Tamara

LGTM patch set 2

Powered by Google App Engine
This is Rietveld