Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: firstRun.html

Issue 29565721: No Issue - Implemented first run page Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed newest round of feedback Created Oct. 20, 2017, 2:43 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | firstRun.js » ('j') | firstRun.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
11 - but WITHOUT ANY WARRANTY; without even the implied warranty of 11 - but WITHOUT ANY WARRANTY; without even the implied warranty of
12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 - GNU General Public License for more details. 13 - GNU General Public License for more details.
14 - 14 -
15 - You should have received a copy of the GNU General Public License 15 - You should have received a copy of the GNU General Public License
16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
17 --> 17 -->
18 18
19 <html> 19 <html>
20 <head> 20 <head>
21 <title class="i18n_firstRun_title"></title> 21 <title class="i18n_firstRun_title"></title>
22 <meta charset="utf-8" /> 22 <meta charset="utf-8" />
23 <meta name="viewport" content="width=device-width, initial-scale=1" /> 23 <meta name="viewport" content="width=device-width, initial-scale=1" />
24 <link type="text/css" href="skin/common.css" rel="stylesheet" /> 24 <link type="text/css" href="skin/common.css" rel="stylesheet" />
25 <link type="text/css" href="skin/defaults.css" rel="stylesheet" />
25 <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/> 26 <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/>
26 <script type="text/javascript" src="polyfill.js"></script> 27 <script type="text/javascript" src="polyfill.js"></script>
27 <script type="text/javascript" src="ext/common.js"></script> 28 <script type="text/javascript" src="ext/common.js"></script>
28 <script type="text/javascript" src="ext/content.js"></script> 29 <script type="text/javascript" src="ext/content.js"></script>
29 <script type="text/javascript" src="common.js"></script> 30 <script type="text/javascript" src="common.js"></script>
30 <script type="text/javascript" src="i18n.js"></script> 31 <script type="text/javascript" src="i18n.js"></script>
31 <script type="text/javascript" src="firstRun.js"></script> 32 <script type="text/javascript" src="firstRun.js"></script>
32 </head> 33 </head>
34
33 <body> 35 <body>
34 36
35 37 <nav id="navbar">
36 <header> 38 <div class="navbar-container">
37 <img id="logo"> 39 <a href="https://adblockplus.org/en/" hreflang="en" id="navbar-logo">
38 <h1 id="title-main" class="i18n_firstRun_title"></h1> 40 <img src="skin/img/navbar-logo.png" srcset="skin/img/navbar-logo.svg 2 x">
Thomas Greiner 2017/10/23 13:17:42 What's the reason for including both PNG as well a
juliandoucette 2017/10/23 13:27:35 He copied and pasted the new abp.org header. It's
martin 2017/10/23 14:43:26 As far as I know SVGs are served on high-dpi displ
Thomas Greiner 2017/10/23 16:45:48 That's indeed a tricky question how much it makes
39 </header> 41 <span>Adblock <strong>Plus</strong></span>
Thomas Greiner 2017/10/23 13:17:42 Please make sure that any text we show in the UI i
juliandoucette 2017/10/23 13:27:34 Is it necessary to make text that we do not transl
martin 2017/10/23 14:43:26 I intentionally didn't i18n this because it's more
Thomas Greiner 2017/10/23 16:45:48 You're right. We're not translating "Adblock Plus"
40 42 </a>
41 <section id="filterlistsReinitializedWarning" class="i18n_firstRun_filterlis tsReinitializedWarning warning" hidden="true"></section> 43 <a href="#" id="navbar-menu-toggle">
42 44 <img src="skin/img/menu-toggle.png" srcset="skin/img/menu-toggle.svg 2 x">
43 <div id="content"> 45 </a>
44 <section id="general"> 46 <ul id="navbar-menu">
45 <div id="acceptable-ads-block" class="block"> 47
46 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> 48 <li>
47 <p id="acceptable-ads-explanation" class="i18n_firstRun_acceptableAdsE xplanation"></p> 49 <a href="https://adblockplus.org/en/about" hreflang="en" class="i1 8n_firstRun_aboutLink"></a>
50 </li>
51
52 <li>
53 <a href="https://adblockplus.org/en/features" hreflang="en" class= "i18n_firstRun_featuresLink"></a>
54 </li>
55
56 <li>
57 <a href="https://adblockplus.org/en/bugs" hreflang="en" class="i18 n_firstRun_reportAnIssueLink"></a>
58 </li>
59
60 <li>
61 <a href="https://adblockplus.org/en/contribute" hreflang="en" clas s="i18n_firstRun_contributeLink"></a>
62 </li>
63
64 <li id="navbar-locale-menubar">
65 <a href="#" id="navbar-locale-selected">
66 English (US)
67 </a>
68 <ul id="navbar-locale-menu">
69
70 <li>
71 <a href="https://adblockplus.org/ar/firefox" hreflang="ar">
juliandoucette 2017/10/21 16:18:42 These hrefs are not correct. We want to translate
Thomas Greiner 2017/10/23 12:01:55 IIRC I brought this up in a UI meeting that it doe
martin 2017/10/23 14:43:25 What I know for sure is that the spec I'm currentl
Thomas Greiner 2017/10/23 16:45:48 Yep, filing a spec issue should be sufficient.
72 العربية (AR)
73 </a>
74 </li>
75
76 <li>
77 <a href="https://adblockplus.org/bg/firefox" hreflang="bg">
78 Български (BG)
79 </a>
80 </li>
81
82 <li>
83 <a href="https://adblockplus.org/de/firefox" hreflang="de">
84 Deutsch (DE)
85 </a>
86 </li>
87
88 <li>
89 <a href="https://adblockplus.org/en/firefox" hreflang="en">
90 English (US)
91 </a>
92 </li>
93
94 <li>
95 <a href="https://adblockplus.org/es/firefox" hreflang="es">
96 Español (España) (LA)
97 </a>
98 </li>
99
100 <li>
101 <a href="https://adblockplus.org/fr/firefox" hreflang="fr">
102 Français (FR)
103 </a>
104 </li>
105
106 <li>
107 <a href="https://adblockplus.org/he/firefox" hreflang="he">
108 עברית (IL)
109 </a>
110 </li>
111
112 <li>
113 <a href="https://adblockplus.org/hu/firefox" hreflang="hu">
114 Magyar (HU)
115 </a>
116 </li>
117
118 <li>
119 <a href="https://adblockplus.org/ko/firefox" hreflang="ko">
120 한국어 (KR)
121 </a>
122 </li>
123
124 <li>
125 <a href="https://adblockplus.org/lt/firefox" hreflang="lt">
126 Lietuvių (LT)
127 </a>
128 </li>
129
130 <li>
131 <a href="https://adblockplus.org/nl/firefox" hreflang="nl">
132 Nederlands (NL)
133 </a>
134 </li>
135
136 <li>
137 <a href="https://adblockplus.org/pt_BR/firefox" hreflang="pt_B R">
138 Português (Brasil) (BR)
139 </a>
140 </li>
141
142 <li>
143 <a href="https://adblockplus.org/ru/firefox" hreflang="ru">
144 Русский (RU)
145 </a>
146 </li>
147
148 <li>
149 <a href="https://adblockplus.org/sk/firefox" hreflang="sk">
150 Slovenčina (SK)
151 </a>
152 </li>
153
154 <li>
155 <a href="https://adblockplus.org/zh_CN/firefox" hreflang="zh_C N">
156 中文(简体) (CN)
157 </a>
158 </li>
159
160 <li>
161 <a href="https://adblockplus.org/zh_TW/firefox" hreflang="zh_T W">
162 中文(台灣) (TW)
163 </a>
164 </li>
165
166 </ul>
167 </li>
168 </ul>
169 </div>
170 </nav>
171
172 <main>
173 <header id="installation-status-header">
174 <img src="skin/icons/first-run/icon-checkmark-header.svg" alt="checkma rk icon">
175 <h1 class="i18n_firstRun_title"></h1>
176 <p class="i18n_firstRun_subtitle"></p>
177 </header>
178
179 <div class="container content">
180
181 <div id="content-columns-container" class="row">
182
183 <section class="column one-third ta-centre">
184 <header class="section-header">
185 <img src="skin/icons/first-run/icon-checkmark.svg" alt="checkmark icon">
186 <h2 class="i18n_firstRun_columnOneTitle"></h2>
187 </header>
188 <p id="first-column-description" class="i18n_firstRun_columnOneDescr iption column-description"></p>
Thomas Greiner 2017/10/23 13:17:41 Detail: The order of the columns may change. Gener
martin 2017/10/23 14:43:26 Completely agree. Will fix that.
189 <a id="options-trigger" class="i18n_firstRun_configure-button button -primary" href="#"></a>
190 </section>
191
192 <section class="column one-third ta-centre">
193 <header class="section-header">
194 <img src="skin/icons/first-run/icon-rocket.svg" alt="rocket icon ">
195 <h2 class="i18n_firstRun_columnTwoTitle"></h2>
196 </header>
197 <p class="i18n_firstRun_columnTwoDescription column-description">< /p>
198 <div class="store-buttons">
199 <a href="" class="store-button applestore-button">
Thomas Greiner 2017/10/23 13:17:42 Don't we have the links for those buttons yet?
martin 2017/10/23 14:43:26 We probably do, however they are not included in t
Thomas Greiner 2017/10/23 16:45:48 Great, thanks.
200 <img src="skin/icons/first-run/appstore-bg.svg" alt="apple sto re button">
201 </a>
202 <a href="" class="store-button googleplay-button">
203 <img src="skin/icons/first-run/googleplay-bg.svg" alt="google play store button">
204 </a>
205 </div>
206 </section>
207
208 <section class="column one-third ta-centre">
209 <header class="section-header">
210 <img src="skin/icons/first-run/icon-lock.svg" alt="padlock icon" >
211 <h2 class="i18n_firstRun_columnThreeTitle"></h2>
212 </header>
213 <p id="third-column-description" class="i18n_firstRun_columnThreeD escription column-description"></p>
214 </section>
215
48 </div> 216 </div>
49 <div id="abb-promotion-block" class="block"> 217
50 <h2 class="i18n_firstRun_abbPromotionHeadline"></h2> 218 </div>
51 <a href="https://adblockbrowser.org/?ref=frp"> 219 </main>
52 <div> 220
53 <img src="skin/abb-logo.png" alt="Adblock Browser logo" /> 221 <footer id="footer" class="content">
54 </div> 222 <div class="container">
55 <div> 223 <div class="row">
56 <div class="i18n_firstRun_abbButtonTitle title"></div> 224 <nav class="column one-fourth">
57 <div class="i18n_firstRun_abbButtonSubtitle subtitle"></div> 225 <h5 class="i18n_firstRun_footerResourcesHeader"></h5>
58 </div> 226 <ul>
59 </a> 227
60 </div> 228 <li><a href="https://adblockplus.org/en/acceptable-ads" class="i 18n_firstRun_footerAcceptableAdsLink" hreflang="en"></a></li>
61 </section> 229
62 230 <li><a href="https://adblockplus.org/en/documentation" class="i1 8n_firstRun_footerDocumentationLink" hreflang="en"></a></li>
63 231
64 <section id="share"> 232 <li><a href="https://adblockplus.org/en/deployments" class="i18n _firstRun_footerForAdminsLink" hreflang="en"></a></li>
65 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2> 233
66 234 </ul>
67 <div class="block"> 235 </nav>
68 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a> 236 <nav class="column one-fourth">
69 <span id="donate-label" class="i18n_firstRun_donate_label"></span> 237 <h5class="i18n_firstRun_footerCommunityHeader"></h5>
juliandoucette 2017/10/21 16:18:42 Missing space.
martin 2017/10/23 14:43:27 Will fix.
70 </div> 238 <ul>
71 239 <li><a href="https://adblockplus.org/releases/" class="i18n_firstR un_footerAnnouncementsLink" hreflang="en"></a></li>
72 <div class="block"> 240 <li><a href="https://adblockplus.org/blog/" class="i18n_firstRun_f ooterBlogLink" hreflang="en"></a></li>
73 <div id="share-general" class="share-buttons"> 241 <li><a href="https://adblockplus.org/forum/" class="i18n_firstRun_ footerForumLink" hreflang="en"></a></li>
74 <a id="share-facebook" href="https://www.facebook.com/adblockplus" t arget="_blank" data-script="https://facebook.com/plugins/like.php?"> 242
75 </a> 243
76 <a id="share-twitter" href="https://twitter.com/adblockplus" target= "_blank" data-script="https://platform.twitter.com/widgets/"> 244 <li><a href="https://adblockplus.org/en/development-builds" class="i18n_ firstRun_footerDevelopmentBuildsLink" hreflang="en"></a></li>
Thomas Greiner 2017/10/23 13:17:42 Detail: Wrong indentation level and inconsisent sp
martin 2017/10/23 14:43:25 Will fix. Sorry about that.
77 </a> 245
78 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" targe t="_blank" data-script="https://apis.google.com/se/0/_/+1/fastbutton?"> 246
79 </a> 247 </ul>
80 </div> 248 </nav>
81 249 <nav class="column one-fourth">
82 <!-- Chinese social networks --> 250 <h5 class="i18n_firstRun_footerDevelopmentHeader"></h5>
83 <div id="share-chinese" class="share-buttons"> 251 <ul>
84 <a id="share-renren" href="http://www.renren.com/601651969" target=" _blank"> 252
85 </a> 253
86 <a id="share-weibo" href="http://e.weibo.com/adblockplus/" target="_ blank"> 254 <li><a href="https://adblockplus.org/en/source" class="i18n_firstRun_foo terSourceCodeLink" hreflang="en"></a></li>
87 </a> 255
88 </div> 256
89 <span class="i18n_firstRun_share"></span> 257 <li><a href="https://issues.adblockplus.org/report/13" class="i18n _firstRun_footerRoadmapLink" hreflang="en"></a></li>
90 </div> 258
91 </section> 259
92 260 <li><a href="https://adblockplus.org/en/tools" class="i18n_firstRun_foot erToolsLink" hreflang="en"></a></li>
93 </div> 261
94 262
95 <footer> 263 <li><a href="https://eyeo.com/jobs/" class="i18n_firstRun_footerJo bsLink" hreflang="en"></a></li>
96 <a id="contributors" class="i18n_firstRun_contributor_credits"></a> 264 </ul>
265 </nav>
266 <nav id="social-list" class="column one-fourth">
267 <h5 class="i18n_firstRun_footerFollowUsHeader"></h5>
268 <ul>
269 <li>
270 <a href="https://twitter.com/AdblockPlus" target="_blank">
271 <img src="skin/img/footer-twitter-glyphicon.png" alt="Twitter" >
Thomas Greiner 2017/10/23 13:17:41 I assume that those icons are were not created by
juliandoucette 2017/10/23 13:27:34 Good question. I'll have to forward it along to pr
272 </a>
273 </li>
274 <li>
275 <a href="https://www.youtube.com/user/AdblockPlusOfficial" targe t="_blank">
276 <img src="skin/img/footer-youtube-glyphicon.png">
277 </a>
278 </li>
279 <li>
280 <a href="https://www.facebook.com/adblockplus" target="_blank">
281 <img src="skin/img/footer-facebook-glyphicon.png">
282 </a>
283 </li>
284 <li>
285 <a href="https://www.instagram.com/adblockplus/" target="_blank" >
286 <img src="skin/img/footer-instagram-glyphicon.png">
287 </a>
288 </li>
289 </ul>
290 </nav>
291 </div>
292 <div id="footer-legal">
293 <p id="copyright-notice" class="i18n_firstRun_footerCopyright"></p>
294 <ul id="legal-list">
295
296 <li><a href="https://adblockplus.org/en/terms" class="i18n_firstRu n_footerTermsOfUseLink" hreflang="en"></a></li>
297
298 <li><a href="https://adblockplus.org/en/privacy" class="i18n_first Run_footerPrivacyPolicyLink" hreflang="en"></a></li>
299
300 <li><a href="https://adblockplus.org/en/impressum" class="i18n_fir stRun_footerLegalNoticeLink" hreflang="en"></a></li>
301
302 </ul>
303 </div>
304 </div>
97 </footer> 305 </footer>
306
98 </body> 307 </body>
308
99 </html> 309 </html>
OLDNEW
« no previous file with comments | « no previous file | firstRun.js » ('j') | firstRun.js » ('J')

Powered by Google App Engine
This is Rietveld