Unified Diff: firstRun.html
Issue 29565721:
No Issue - Implemented first run page
Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set:
Created Oct. 5, 2017, 1:47 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
firstRun.js » ('j')
|
skin/firstRun.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: firstRun.html |
| =================================================================== |
| --- a/firstRun.html |
| +++ b/firstRun.html |
| @@ -24,75 +24,51 @@ |
| <link type="text/css" href="skin/common.css" rel="stylesheet" /> |
| <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/> |
| <script type="text/javascript" src="ext/common.js"></script> |
| <script type="text/javascript" src="ext/content.js"></script> |
| <script type="text/javascript" src="common.js"></script> |
| <script type="text/javascript" src="i18n.js"></script> |
| <script type="text/javascript" src="firstRun.js"></script> |
| </head> |
| + |
| <body> |
|
juliandoucette
2017/10/08 13:18:10
NIT: You should wrap the content currently on this
martin
2017/10/16 09:09:08
Done.
|
| - |
| <header> |
| - <img id="logo"> |
| - <h1 id="title-main" class="i18n_firstRun_title"></h1> |
| + <img src="./skin/icons/first-run/icon-checkmark-header.svg" alt="checkmark icon"> |
|
juliandoucette
2017/10/08 13:18:10
NIT: Alt text should be translated
(The same appl
juliandoucette
2017/10/08 13:18:10
NIT: "./" is unnecessary here
(The same applies e
martin
2017/10/16 09:09:08
I honestly don't know how to do that with the curr
saroyanm
2017/10/16 10:22:59
text inside of attributes can't be easily translat
martin
2017/10/16 14:36:00
Done.
|
| + <h1 class="i18n_firstRun_title"></h1> |
| + <p class="i18n_firstRun_subtitle"></p> |
| </header> |
| - <section id="filterlistsReinitializedWarning" class="i18n_firstRun_filterlistsReinitializedWarning warning" hidden="true"></section> |
| + <div class="container content"> |
| + |
| + <div class="row"> |
| - <div id="content"> |
| - <section id="general"> |
| - <div id="acceptable-ads-block" class="block"> |
| - <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> |
| - <p id="acceptable-ads-explanation" class="i18n_firstRun_acceptableAdsExplanation"></p> |
| - </div> |
| - <div id="abb-promotion-block" class="block"> |
| - <h2 class="i18n_firstRun_abbPromotionHeadline"></h2> |
| - <a href="https://adblockbrowser.org/?ref=frp"> |
| - <div> |
| - <img src="skin/abb-logo.png" alt="Adblock Browser logo" /> |
| - </div> |
| - <div> |
| - <div class="i18n_firstRun_abbButtonTitle title"></div> |
| - <div class="i18n_firstRun_abbButtonSubtitle subtitle"></div> |
| - </div> |
| - </a> |
| - </div> |
| - </section> |
| - |
| - |
| - <section id="share"> |
| - <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2> |
| - |
| - <div class="block"> |
| - <a id="donate" class="i18n_firstRun_donate" target="_blank"></a> |
| - <span id="donate-label" class="i18n_firstRun_donate_label"></span> |
| + <div class="column one-third"> |
|
juliandoucette
2017/10/08 13:18:10
NIT: These (columns) should be <article>s
(See ht
martin
2017/10/16 09:09:08
Done.
|
| + <img src="./skin/icons/first-run/icon-checkmark.svg" alt="checkmark icon"> |
| + <h2 class="i18n_firstRun_columnOneTitle"></h2> |
|
juliandoucette
2017/10/08 13:18:10
NIT: I think that you should wrap the <img> and th
martin
2017/10/16 09:09:09
Done.
|
| + <p id="first-column-description" class="i18n_firstRun_columnOneDescription"></p> |
| + <a id="options-trigger" class="i18n_firstRun_configure-button button-primary" href="#"></a> |
| </div> |
| - <div class="block"> |
| - <div id="share-general" class="share-buttons"> |
| - <a id="share-facebook" href="https://www.facebook.com/adblockplus" target="_blank" data-script="https://facebook.com/plugins/like.php?"> |
| - </a> |
| - <a id="share-twitter" href="https://twitter.com/adblockplus" target="_blank" data-script="https://platform.twitter.com/widgets/"> |
| - </a> |
| - <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target="_blank" data-script="https://apis.google.com/se/0/_/+1/fastbutton?"> |
| - </a> |
| - </div> |
| + <div class="column one-third"> |
| + <img src="./skin/icons/first-run/icon-rocket.svg" alt="rocket icon"> |
| + <h2 class="i18n_firstRun_columnTwoTitle"></h2> |
| + <p class="i18n_firstRun_columnTwoDescription"></p> |
| + <div class="store-buttons"> |
| + <a href="" class="store-button applestore-button"></a> |
|
juliandoucette
2017/10/08 13:18:10
NIT: There is no text in this button
You could us
martin
2017/10/16 09:09:09
Soo... I *think* what you mean is that instead of
juliandoucette
2017/10/16 10:00:38
~Yes.
I suggested the following solutions:
1. Pl
martin
2017/10/16 14:36:00
Done. I went for option 2.
|
| + <a href="" class="store-button googleplay-button"></a> |
| + </div> |
| + </div> |
| - <!-- Chinese social networks --> |
| - <div id="share-chinese" class="share-buttons"> |
| - <a id="share-renren" href="http://www.renren.com/601651969" target="_blank"> |
| - </a> |
| - <a id="share-weibo" href="http://e.weibo.com/adblockplus/" target="_blank"> |
| - </a> |
| - </div> |
| - <span class="i18n_firstRun_share"></span> |
| + <div class="column one-third"> |
| + <img src="./skin/icons/first-run/icon-lock.svg" alt="padlock icon"> |
| + <h2 class="i18n_firstRun_columnThreeTitle"></h2> |
| + <p id="third-column-description" class="i18n_firstRun_columnThreeDescription"></p> |
| </div> |
| - </section> |
| + |
| + </div> |
| </div> |
| - <footer> |
| - <a id="contributors" class="i18n_firstRun_contributor_credits"></a> |
| - </footer> |
| </body> |
| + |
| </html> |
« no previous file with comments
|
« no previous file
|
firstRun.js » ('j')
|
skin/firstRun.css » ('J')
