Unified Diff: firstRun.html
Issue 29565721:
No Issue - Implemented first run page
Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed newest round of feedback (2)
Created Oct. 26, 2017, 10:29 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
firstRun.js » ('j')
|
skin/firstRun.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: firstRun.html |
| =================================================================== |
| --- a/firstRun.html |
| +++ b/firstRun.html |
| @@ -9,91 +9,173 @@ |
| - |
| - Adblock Plus is distributed in the hope that it will be useful, |
| - but WITHOUT ANY WARRANTY; without even the implied warranty of |
| - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| - GNU General Public License for more details. |
| - |
| - You should have received a copy of the GNU General Public License |
| - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. |
| - --> |
| +--> |
| <html> |
| - <head> |
| - <title class="i18n_firstRun_title"></title> |
| - <meta charset="utf-8" /> |
| - <meta name="viewport" content="width=device-width, initial-scale=1" /> |
| - <link type="text/css" href="skin/common.css" rel="stylesheet" /> |
| - <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/> |
| - <script type="text/javascript" src="polyfill.js"></script> |
| - <script type="text/javascript" src="ext/common.js"></script> |
| - <script type="text/javascript" src="ext/content.js"></script> |
| - <script type="text/javascript" src="common.js"></script> |
| - <script type="text/javascript" src="i18n.js"></script> |
| - <script type="text/javascript" src="firstRun.js"></script> |
| - </head> |
| - <body> |
| +<head> |
| + <title class="i18n_firstRun_title"></title> |
| + <meta charset="utf-8" /> |
| + <meta name="viewport" content="width=device-width, initial-scale=1" /> |
| + <link type="text/css" href="skin/common.css" rel="stylesheet" /> |
| + <link type="text/css" href="skin/defaults.css" rel="stylesheet" /> |
| + <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/> |
| + <script type="text/javascript" src="polyfill.js"></script> |
| + <script type="text/javascript" src="ext/common.js"></script> |
| + <script type="text/javascript" src="ext/content.js"></script> |
| + <script type="text/javascript" src="common.js"></script> |
| + <script type="text/javascript" src="i18n.js"></script> |
| + <script type="text/javascript" src="firstRun.js"></script> |
| +</head> |
| +<body> |
| + |
| + <nav id="navbar"> |
|
juliandoucette
2017/10/30 15:02:27
NIT: I've made several small updates to the navbar
martin
2018/01/30 14:10:02
Done.
|
| + <div class="navbar-container"> |
| + <a href="https://adblockplus.org/en/" hreflang="en" id="navbar-logo"> |
| + <img src="skin/img/navbar-logo.svg"> |
| + <span>Adblock <strong>Plus</strong></span> |
| + </a> |
| + <a href="#" id="navbar-menu-toggle"> |
| + <img src="skin/img/menu-toggle.svg"> |
| + </a> |
| + <ul id="navbar-menu"> |
| + <li> |
| + <a href="https://adblockplus.org/en/about" hreflang="en" class="i18n_firstRun_aboutLink"></a> |
| + </li> |
| - <header> |
| - <img id="logo"> |
| - <h1 id="title-main" class="i18n_firstRun_title"></h1> |
| - </header> |
| + <li> |
| + <a href="https://adblockplus.org/en/features" hreflang="en" class="i18n_firstRun_featuresLink"></a> |
| + </li> |
| - <section id="filterlistsReinitializedWarning" class="i18n_firstRun_filterlistsReinitializedWarning warning" hidden="true"></section> |
| + <li> |
| + <a href="https://adblockplus.org/en/bugs" hreflang="en" class="i18n_firstRun_reportAnIssueLink"></a> |
| + </li> |
| - <div id="content"> |
| - <section id="general"> |
| - <div id="acceptable-ads-block" class="block"> |
| - <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> |
| - <p id="acceptable-ads-explanation" class="i18n_firstRun_acceptableAdsExplanation"></p> |
| - </div> |
| - <div id="abb-promotion-block" class="block"> |
| - <h2 class="i18n_firstRun_abbPromotionHeadline"></h2> |
| - <a href="https://adblockbrowser.org/?ref=frp"> |
| - <div> |
| - <img src="skin/abb-logo.png" alt="Adblock Browser logo" /> |
| - </div> |
| - <div> |
| - <div class="i18n_firstRun_abbButtonTitle title"></div> |
| - <div class="i18n_firstRun_abbButtonSubtitle subtitle"></div> |
| - </div> |
| - </a> |
| - </div> |
| - </section> |
| - |
| - |
| - <section id="share"> |
| - <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2> |
| - |
| - <div class="block"> |
| - <a id="donate" class="i18n_firstRun_donate" target="_blank"></a> |
| - <span id="donate-label" class="i18n_firstRun_donate_label"></span> |
| - </div> |
| - |
| - <div class="block"> |
| - <div id="share-general" class="share-buttons"> |
| - <a id="share-facebook" href="https://www.facebook.com/adblockplus" target="_blank" data-script="https://facebook.com/plugins/like.php?"> |
| + <li> |
| + <a href="https://adblockplus.org/en/contribute" hreflang="en" class="i18n_firstRun_contributeLink"></a> |
| + </li> |
| + </ul> |
| + </div> |
| + </nav> |
| + |
| + <main> |
| + <header id="installation-status-header"> |
| + <img src="skin/icons/first-run/icon-checkmark-header.svg" alt="checkmark icon"> |
| + <h1 class="i18n_firstRun_title"></h1> |
| + <p class="i18n_firstRun_subtitle"></p> |
| + </header> |
| + |
| + <div id="main-content-container" class="container content"> |
|
juliandoucette
2017/10/30 15:02:27
NIT/Suggest: Replace the id "main-content-containe
martin
2018/01/30 14:10:02
Done.
|
| + |
| + <div id="content" class="row"> |
|
juliandoucette
2017/10/30 15:02:27
NIT: I don't think that centred text looks good at
|
| + |
| + <section class="column one-third ta-centre"> |
|
juliandoucette
2017/10/30 15:02:27
NIT: If you add ta-center to the parent, all child
martin
2018/01/30 14:10:03
Done.
|
| + <header class="section-header"> |
| + <img src="skin/icons/first-run/icon-checkmark.svg" alt="checkmark icon"> |
| + <h2 class="i18n_firstRun_columnOneTitle"></h2> |
| + </header> |
| + <p id="first-column-description" class="i18n_firstRun_controlDescription column-description"></p> |
| + <a id="options-trigger" class="i18n_firstRun_configure-button button-primary" href="#"></a> |
| + </section> |
| + |
| + <section class="column one-third ta-centre"> |
| + <header class="section-header"> |
| + <img src="skin/icons/first-run/icon-rocket.svg" alt="rocket icon"> |
| + <h2 class="i18n_firstRun_columnTwoTitle"></h2> |
| + </header> |
| + <p class="i18n_firstRun_browserAppDescription column-description"></p> |
| + <div class="store-buttons"> |
| + <a href="" class="store-button applestore-button"> |
| + <img src="skin/icons/first-run/appstore-bg.svg" alt="apple store button"> |
| </a> |
| - <a id="share-twitter" href="https://twitter.com/adblockplus" target="_blank" data-script="https://platform.twitter.com/widgets/"> |
| - </a> |
| - <a id="share-gplus" href="https://www.google.com/+AdblockPlus" target="_blank" data-script="https://apis.google.com/se/0/_/+1/fastbutton?"> |
| + <a href="" class="store-button googleplay-button"> |
| + <img src="skin/icons/first-run/googleplay-bg.svg" alt="google play store button"> |
| </a> |
| </div> |
| + </section> |
| + |
| + <section class="column one-third ta-centre"> |
| + <header class="section-header"> |
| + <img src="skin/icons/first-run/icon-lock.svg" alt="padlock icon"> |
| + <h2 class="i18n_firstRun_columnThreeTitle"></h2> |
| + </header> |
| + <p id="third-column-description" class="i18n_firstRun_fairUseDescription column-description"></p> |
| + </section> |
| + </div> |
| + </div> |
| + </main> |
| + |
| + <footer id="footer" class="content"> |
| + <div class="container"> |
| + <div class="row"> |
| + <nav class="column one-fourth"> |
| + <h5 class="i18n_firstRun_footerResourcesHeader"></h5> |
| + <ul> |
| + <li><a href="https://adblockplus.org/en/acceptable-ads" class="i18n_firstRun_footerAcceptableAdsLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/en/documentation" class="i18n_firstRun_footerDocumentationLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/en/deployments" class="i18n_firstRun_footerForAdminsLink" hreflang="en"></a></li> |
| + </ul> |
| + </nav> |
| + <nav class="column one-fourth"> |
| + <h5 class="i18n_firstRun_footerCommunityHeader"></h5> |
| + <ul> |
| + <li><a href="https://adblockplus.org/releases/" class="i18n_firstRun_footerAnnouncementsLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/blog/" class="i18n_firstRun_footerBlogLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/forum/" class="i18n_firstRun_footerForumLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/en/development-builds" class="i18n_firstRun_footerDevelopmentBuildsLink" hreflang="en"></a></li> |
| + </ul> |
| + </nav> |
| + <nav class="column one-fourth"> |
| + <h5 class="i18n_firstRun_footerDevelopmentHeader"></h5> |
| + <ul> |
| + <li><a href="https://adblockplus.org/en/source" class="i18n_firstRun_footerSourceCodeLink" hreflang="en"></a></li> |
| + <li><a href="https://issues.adblockplus.org/report/13" class="i18n_firstRun_footerRoadmapLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/en/tools" class="i18n_firstRun_footerToolsLink" hreflang="en"></a></li> |
| + <li><a href="https://eyeo.com/jobs/" class="i18n_firstRun_footerJobsLink" hreflang="en"></a></li> |
| + </ul> |
| + </nav> |
| + <nav id="social-list" class="column one-fourth"> |
| + <h5 class="i18n_firstRun_footerFollowUsHeader"></h5> |
| + <ul> |
| + <li> |
| + <a href="https://twitter.com/AdblockPlus" target="_blank"> |
| + <img src="skin/img/footer-twitter-glyphicon.png" alt="Twitter"> |
| + </a> |
| + </li> |
| + <li> |
| + <a href="https://www.youtube.com/user/AdblockPlusOfficial" target="_blank"> |
| + <img src="skin/img/footer-youtube-glyphicon.png"> |
| + </a> |
| + </li> |
| + <li> |
| + <a href="https://www.facebook.com/adblockplus" target="_blank"> |
| + <img src="skin/img/footer-facebook-glyphicon.png"> |
| + </a> |
| + </li> |
| + <li> |
| + <a href="https://www.instagram.com/adblockplus/" target="_blank"> |
| + <img src="skin/img/footer-instagram-glyphicon.png"> |
| + </a> |
| + </li> |
| + </ul> |
| + </nav> |
| + </div> |
| + <div id="footer-legal"> |
| + <p id="copyright-notice" class="i18n_firstRun_footerCopyright"></p> |
| + <ul id="legal-list"> |
| + <li><a href="https://adblockplus.org/en/terms" class="i18n_firstRun_footerTermsOfUseLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/en/privacy" class="i18n_firstRun_footerPrivacyPolicyLink" hreflang="en"></a></li> |
| + <li><a href="https://adblockplus.org/en/impressum" class="i18n_firstRun_footerLegalNoticeLink" hreflang="en"></a></li> |
| + </ul> |
| + </div> |
| + </div> |
| + </footer> |
| + |
| +</body> |
| - <!-- Chinese social networks --> |
| - <div id="share-chinese" class="share-buttons"> |
| - <a id="share-renren" href="http://www.renren.com/601651969" target="_blank"> |
| - </a> |
| - <a id="share-weibo" href="http://e.weibo.com/adblockplus/" target="_blank"> |
| - </a> |
| - </div> |
| - <span class="i18n_firstRun_share"></span> |
| - </div> |
| - </section> |
| - |
| - </div> |
| - |
| - <footer> |
| - <a id="contributors" class="i18n_firstRun_contributor_credits"></a> |
| - </footer> |
| - </body> |
| </html> |
« no previous file with comments
|
« no previous file
|
firstRun.js » ('j')
|
skin/firstRun.css » ('J')
