No Issue - Implemented first run page

skin/firstRun.css

Index: skin/firstRun.css
===================================================================
--- a/skin/firstRun.css
+++ b/skin/firstRun.css
@@ -1,519 +1,630 @@
 /*

[Thomas Greiner, 2018/02/16 16:19:15]

It is difficult to distinguish styles that are coming from websites-defaults
from styles you introduced for the purpose of the first-run page. However, both
are mixed together in "firstRun.css", implying that all of those were made
specifically for the first-run page.

Therefore, I strongly suggest to split those styles up and only include styles
specifically created for the first-run page in here.

Thereby you can keep any non-relevant styles (e.g. ones targeting IE9) but in a
separate file so that we know that we've simply imported them from Websites and
don't need to change them.

- * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-present eyeo GmbH
- *
- * Adblock Plus is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 3 as
- * published by the Free Software Foundation.
- *
- * Adblock Plus is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
- */
+  * This file is part of Adblock Plus <https://adblockplus.org/>,
+  * Copyright (C) 2006-present eyeo GmbH
+  *
+  * Adblock Plus is free software: you can redistribute it and/or modify
+  * it under the terms of the GNU General Public License version 3 as
+  * published by the Free Software Foundation.
+  *
+  * Adblock Plus is distributed in the hope that it will be useful,
+  * but WITHOUT ANY WARRANTY; without even the implied warranty of
+  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  * GNU General Public License for more details.
+  *
+  * You should have received a copy of the GNU General Public License
+  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+*/

[Thomas Greiner, 2018/02/16 16:19:15]

Detail: What happened to the whitespaces here?

 
-@font-face {
-  font-family: "CreteRound";
+@font-face 
+{
+  font-family: "Source Sans Pro";
   font-style: normal;
-  src: url(fonts/CreteRound-Regular.otf);
+  font-weight: 400;
+  font-stretch: normal;
   src: local ("Ø"),
-  /*local ("Ø") forces using no local font called CreteRound*/
-  url(fonts/CreteRound-Regular.otf) format("otf");
+  url(fonts/SourceSansPro-Regular.woff) format("woff");
 }
 
-@font-face {
-  font-family: "CreteRound";
-  font-style: italic;
-  src: url(fonts/CreteRound-Italic.otf);
+@font-face
+{
+  font-family: "Source Sans Pro";
+  font-style: bold;
+  font-weight: 700;
+  font-stretch: normal;
   src: local ("Ø"),
-  /*local ("Ø") forces using no local font called CreteRound*/
-  url(fonts/CreteRound-Italic.otf) format("otf");
+  url(fonts/SourceSansPro-bold.woff) format("woff");
+}
+
+html
+{
+  font-family: "Source Sans Pro", Helvetica, Arial, sans-serif;
 }
 
 body
 {
-  font-family: Helvetica, Arial, sans-serif;
-  font-size: 15px;
-  line-height: 140%;
-  color: #7f776b;
-  background-color: #f8f6f2;
-  background-image: url(background-main.png);
-  margin: 0;
-  padding: 0;
-}
-
-a, a:link, a:visited
-{
-  color: #5a84b3;
-  text-decoration: underline;
-}
-
-a:hover
-{
-  text-decoration: none;
-}
-
-button
-{
-  cursor: pointer;
-}
-
-ul
-{
   margin: 0;
   padding: 0;
 }
 
-li
-{
-  margin: 0;
-  padding: 0;
-  list-style-type: none;
-}
-
-header
-{
-  background-image: url(background.png);
-  background-repeat: repeat-x;
-  width: 100%;
-  padding-top: 25px;
-}
-
-header h1
-{
-  font-size: 24px;
-  font-weight: normal;
-  color: #57ab5b;
-  text-align: center;
-  margin: 21px auto;
-  padding: 16px 0px;
-  border: 1px #57ab5b;
-  border-style: dashed none;
-  /* border parallel fix - 957px is the value
-   * closest to 960px(page width) which makes
-   * the dashed border parallel
-   */
-  max-width: 957px;
-}
-
-h1,
-h2,
-h3
-{
- font-family: CreteRound, Helvetica, Arial, sans-serif;
-}
-
-h2
-{
-  font-size: 26px;
-  font-weight: lighter;
-  color: #968d81;
-  line-height: 28px;
-  text-align: center;
-  margin: 0;
-  padding: 0;
-}
-
-h3
-{
-  font-size: 22px;
-  color: #7F776B;
-  font-weight: normal;
-  margin-top: 0px;
-  margin-bottom: 10px;
-  padding: 0;
-  line-height: 24px;
-}
-
-h4
-{
-  font-size: 15px;
-  color: #7f776b;
-  font-weight: normal;
-  text-align: center;
-  margin: 0;
-  padding: 0;
-}
-
-section
-{
-  margin: 0 auto;
-  margin-bottom: 30px;
-  max-width: 960px;
-  background-image: url(background.png);
-  padding: 40px 100px;
-  box-sizing: border-box;
-}
-
-#general
-{
-  display: table;
-  padding-left: 0px;
-  padding-right: 0px;
-}
-
-#general > .block
-{
-  display: table-cell;
-  width: 50%;
-  vertical-align: top;
-  padding: 0px 50px;
-  border: dashed 0 #969085;
-  -webkit-border-start-width: 1px;
-  -moz-border-start-width: 1px;
-  border-inline-start-width: 1px;
-}
-
-#general > .block:first-child
-{
-  border: none;
-}
-
-#acceptable-ads-block h2
-{
-  margin-bottom: 34px;
-}
-
-#abb-promotion-block:lang(fr)
-{
-  display: none;
-}
-
-#abb-promotion-block
+.ta-centre
 {
   text-align: center;
 }
 
-#abb-promotion-block h2
-{
-  color: #7795b6;
-  margin-bottom: 40px;
+#content {
+  margin-bottom: 3em;
 }
 
-#abb-promotion-block a
+@media (max-width: 992px) 
 {
-  border: solid 1px #446a96;
-  border-radius: 5px;
-  display: inline-block;
-  padding: 6px 16px;
-  background: -webkit-linear-gradient(bottom, #294e76, #6b92be);
-  background: linear-gradient(to top, #294e76, #6b92be);
-  text-decoration: none;
-  text-align: start;
+  #content .one-third 
+  {
+    padding: 3em 2em;
+    border-bottom: 1px solid #d3d3d3;
+  }
+  #content .one-third:last-child {
+    border-bottom: none;
+  }
 }
 
-#abb-promotion-block a > div
+/******************************************************************************
+  * .content
+*****************************************************************************/

[Thomas Greiner, 2018/02/16 16:19:17]

Detail: Missing whitespace at beginning of line causing the line to be offset a
bit.

Also applies to other occurrences in this file.

+
+.content h1,
+.content h2,
+.content h3,
+.content h4,
+.content h5
 {
-  display: table-cell;
-  vertical-align: middle;
-  padding: 6px;
+  font-weight: bold;

[Thomas Greiner, 2018/02/16 16:19:19]

We consistently use number values for the font weight across all our files to
avoid confusion so please use `700` here.

+  margin: 32px 0px;

[Thomas Greiner, 2018/02/16 16:19:19]

Coding style: "Omit unit specification after “0” values, unless required."

Also applies to other occurrences in this file.

See https://google.github.io/styleguide/htmlcssguide.html#0_and_Units

+  margin: 2rem 0rem;
 }
 
-#abb-promotion-block .title
+.content h1 { font-size: 1.8em; }
+.content h2 { font-size: 1.4em; }
+.content h3 { font-size: 1.3em; }
+.content h4 { font-size: 1.2em; }
+.content h5 { font-size: 1.1em; }
+
+@media(min-width: 768px)
 {
-  font-size: 21px;
-  color: #ffffff;
-  font-weight: bold;
-}
-
-#abb-promotion-block .subtitle
-{
-  font-size: 12px;
-  color: #9ab7d6;
+  .content h1 { font-size: 2.4em; }
+  .content h2 { font-size: 1.6em; }
 }
 
-#abb-promotion-block a:hover
+.content a,
+.content a:visited
 {
-  box-shadow: 0px 0px 5px #5D5D5D;
+  color: #C70D2C;
 }
 
-#abb-promotion-block a:active
+/*******************************************************************************
+ * #navbar
+ ******************************************************************************/
+
+#navbar
 {
-  box-shadow: 0px 0px 5px 1px #5D5D5D;
-}
-
-section > p
-{
-  margin-top: 15px;
+  min-height: 4em;
+  background-color: #c70d2c;
 }
 
-#logo
+@media(max-width: 991px)
 {
-  margin: 0 auto;
-  height: 128px;
-  width: 128px;
-  display: block;
+  #navbar
+  {
+    overflow: auto;
+  }
+}
+
+#navbar li
+{
+  list-style-type: none;
 }
 
-#share
+#navbar .container
 {
-  background-image: url(background-share.png);
-  text-align: center;
-  font-family: CreteRound, Helvetica, Arial, sans-serif;
+  padding-left: 0;
+  padding-right: 0;
 }
 
-#share h2
+/* #navbar #navbar-logo
+ ******************************************************************************/
+
+#navbar-logo
 {
-  margin-bottom: 30px;
-}
-
-#share h2,
-#share h2 > a
-{
+  /* padding is visible in hover background-color change */
+  padding: 0em 1em;
   color: #fff;
 }
 
-#share h2 > a:hover
+#navbar-logo:hover,
+#navbar-logo:active,
+#navbar-logo:focus
 {
-  color: #2e5075;
-}
-
-#share span
-{
-  color: #bed1e6;
-  text-align: center;
-  line-height: 34px;
-  font-size: 22px;
-  display: block;
+  background-color: #AE0013;
+  text-decoration: none;
 }
 
-#donate:hover, .share-buttons a:hover
+#navbar-logo,
+#navbar-logo > *
 {
-  box-shadow: 0px 0px 0px 2px #8ca7c4;
-  border-radius: 30px;
+  float: left;
 }
 
-#share > .block
+[dir="rtl"] #navbar-logo,
+[dir="rtl"] #navbar-logo > *
 {
-  display: inline-block;
-  vertical-align: top;
-  width: 49%;
-  padding: 5px 0px;
-  border: 1px dashed #37506d;
-  border-style: none dashed;
+  float: right;
+}
+
+#navbar-logo img
+{
+  height: 4em;
+  padding: 0.5em 0em;
+  margin: 0em 1em 0em 0em;
 }
 
-#share > .block:last-child
+[dir="rtl"] #navbar-logo > img
 {
-  -webkit-border-start-style: none;
-  -moz-border-start-style: none;
+  margin: 0em  0em 0em 1em;
 }
 
-#share > .block > span
+#navbar-logo > span
 {
-  margin: 10px 20px;
+  /* full-height: 2.91 * 1.375 = ~4em */
+  line-height: 2.91em;
+  font-size: 1.375em;
 }
 
-.share-buttons
+/* #navbar #navbar-menu-toggle
+ ******************************************************************************/
+
+#navbar-menu-toggle
 {
-  margin-top: 6px;
-  vertical-align: top;
-  /* because inline block creates
-   * space if not captured with
-   * font-size and line-height 0px
-   */
-  font-size: 0px;
-  line-height: 0px;
+  float: right;
+  padding: 1em;
 }
 
-.share-buttons > a
+[dir="rtl"] #navbar-menu-toggle
 {
-  width: 50px;
-  height: 50px;
-  margin: 0 8px;
-  text-decoration: none;
-  display: inline-block;
+  float: left;
 }
 
-#share-general,
-#share-chinese:lang(zh)
+/* show on mobile */
+#navbar-menu-toggle,
+#navbar-menu-toggle > img
 {
   display: block;
 }
 
-#share-general:lang(zh),
-#share-chinese
+/* hide on desktop */
+@media(min-width: 992px)
+{
+  #navbar-menu-toggle
+  {
+    display: none;
+  }
+}
+
+#navbar-menu-toggle > img
+{
+  /* plus 2em padding = 4em */
+  height: 2em;
+}
+
+#navbar-menu-toggle:hover,
+#navbar-menu-toggle:active,
+#navbar-menu-toggle:focus
+{
+  background-color: #AE0013;
+}
+
+/* #navbar #navbar-menu
+ ******************************************************************************/
+
+#navbar-menu a
+{
+  display: block;
+  color: #fff;
+  text-decoration: none;
+}
+
+/* #navbar #navbar-menu #navbar-locale-menu
+ ******************************************************************************/
+
+/* caret */
+#navbar-locale-selected:after
+{
+  display: inline-block;
+  width: 0;
+  height: 0;
+  margin: 0em 0em 0em 0.255em;
+  vertical-align: .255em;

[Thomas Greiner, 2018/02/16 16:19:16]

Coding style: "Don't omit the optional leading 0 for decimal numbers."

Also applies to other occurrences in this file.

+  content: "";
+  border-top: .3em solid;
+  border-right: .3em solid transparent;
+  border-left: .3em solid transparent;
+}
+
+[dir="rtl"] #navbar-locale-selected:after
+{
+  margin: 0em 0.255em 0em 0em;
+}
+
+#navbar-locale-menu
 {
   display: none;
 }
 
-#share-chinese > a
-{
-  border-bottom: 2px solid transparent;
-}
-
-#share-chinese > a:hover
-{
-  box-shadow: none;
-  border-radius: 0;
-  border-bottom: 2px solid #8CA7C4;
-}
-
-#share-facebook
+#navbar-locale-menu.visible
 {
-  background-image: url(social/facebook.png);
-  background-repeat: no-repeat;
-}
-
-#share-twitter
-{
-  background-image: url(social/twitter.png);
-  background-repeat: no-repeat;
-}
-
-#share-gplus
-{
-  background-image: url(social/googleplus.png);
-  background-repeat: no-repeat;
+  display: block;
 }
 
-#share-renren
+#navbar-locale-menu > li > a
 {
-  background-image: url(social/renren.png);
-  background-repeat: no-repeat;
-}
-
-#share-weibo
-{
-  background-image: url(social/weibo.png);
-  background-repeat: no-repeat;
+  padding: 0.75em 1em;
 }
 
-.warning
-{
-  font-size: 160%;
-  border: 3px dashed red;
-  text-align: center;
-  line-height: 1.3em;
-}
-
-#social ul
+#navbar-locale-menu > li > a:hover,
+#navbar-locale-menu > li > a:active,
+#navbar-locale-menu > li > a:focus
 {
-  list-style: none;
-  display: inline-block;
-  padding: 0;
-  margin: 0;
-}
-
-#social:hover h1
-{
-  opacity: 0;
-}
-
-#social ul:hover li {
-  opacity: 0.3;
+  background-color: #434343;
 }
 
-#social ul li
+/* #navbar #navbar-menu (desktop)
+ ******************************************************************************/
+
+@media(min-width: 992px)
 {
-  display: inline-block;
-  margin: 0px 5px;
-  -webkit-transition: opacity .5s ease, bottom .3s ease;
-  transition: opacity .5s ease, bottom .3s ease;
-  position: relative;
-  bottom: -30px;
-}
+  #navbar-menu
+  {
+    float: right;
+  }
+
+  [dir="rtl"] #navbar-menu
+  {
+    float: left;
+  }
 
-#social ul li:hover
-{
-  opacity: 1.0;
-  bottom: 0px;
-}
+  #navbar-menu > li,
+  #navbar-menu > li > a
+  {
+    display: inline-block;
+  }
+
+  #navbar-menu > li > a
+  {
+    padding: 0em 1em;
+    line-height: 4em;
+  }
 
-.share-button
-{
-  display: inline-block;
-  width: 82px;
-  height: 82px;
-}
+  #navbar-menu > li > a:hover,
+  #navbar-menu > li > a:active,
+  #navbar-menu > li > a:focus
+  {
+    background-color: #AE0013;
+  }
+
+  /* #navbar #navbar-menu #navbar-locale-menu

[Thomas Greiner, 2018/02/16 16:19:20]

You don't include this section of the navbar so let's not include its styles
either.

+   ****************************************************************************/
+
+  #navbar-locale-menubar
+  {
+    position: relative;
+  }
 
-/* Change order of the blocks for French */
-#content:lang(fr)
-{
-  display: table;
-  margin: auto;
-  caption-side: bottom;
-}
+  #navbar-locale-menu
+  {
+    position: absolute;
+    min-width: 16em;
+    max-height: 20em;
+    max-height: 50vh;
+    top: 100%;
+    right: 0px;
+    overflow: auto;
+    z-index: 9001;
+    background-color: #292929;
+  }
 
-#share:lang(fr)
-{
-  display: table-caption;
+  [dir="rtl"] #navbar-locale-menu
+  {
+    right: auto;
+    left: 0px;
+  }
 }
 
-#donate
+/* #navbar #navbar-menu (mobile)
+ ******************************************************************************/
+
+@media(max-width: 991px)
 {
-  height: 21px;
-  display: inline-block;
-  margin-top: 15px;
-  margin-bottom: 2px;
-  font-size: 16px;
-  color: #003366;
-  cursor: pointer;
-  font-weight: bold;
-  padding: 5px 18px;
-  text-decoration: none;
-  border-radius: 20px;
-  border: 1px solid #FF9933;
-  overflow: hidden;
-  font-family: arial, sans-serif;
-  background-image: url(donate.png);
-  background-repeat: repeat-x;
-}
-
-footer
-{
-  margin: 0 auto 30px;
-  max-width: 960px;
-  text-align: center;
-}
-
-@media (max-width: 970px)
-{
-  header
+  #navbar-menu
   {
-    background-size: 100px 57px;
+    display: none;
+    float: left;

[Thomas Greiner, 2018/02/16 16:19:18]

I don't see a rule for reversing this for right-to-left locales.

+    clear: both;
+    width: 100%;
+    background-color: #292929;
   }
 
-  #logo
-  {
-    width: 64px;
-    height: 64px;
-  }
-
-  section
-  {
-    padding: 40px 20px;
-  }
-
-  #general,
-  #general > .block,
-  #share > .block
+  #navbar-menu.visible
   {
     display: block;
   }
 
-  #general > .block
+  #navbar-menu li a
   {
-    width: auto;
-    margin-left: 20px;
-    margin-right: 20px;
-    padding: 10px 0px;
-    border-width: 1px 0px 0px;
+    padding: 0.75em 1em;
   }
 
-  #share > .block
+  #navbar-menu li a:hover,
+  #navbar-menu li a:active,
+  #navbar-menu li a:focus
+  {
+    background-color: #434343;
+  }
+}
+
+/******************************************************************************
+  * Main Page Content
+*****************************************************************************/
+
+#installation-status-header
+{
+  text-align: center;
+  background: #f9f9f9;

[Thomas Greiner, 2018/02/16 16:19:20]

Detail: Do you actually want to override other background-* properties or do you
merely want to change the color? Because for the latter, using
"background-color" would make this more maintainable.

Also applies to other occurrences in this file.

+  padding: 4em 0;
+  margin-bottom: 4em;
+}
+
+#installation-status-header > h1 {
+  text-transform: uppercase;
+}
+
+.section-header > h2
+{
+  margin: 1em 0 0;
+}
+
+.button-primary
+{
+  display: inline-block;
+  text-decoration: none;
+  text-transform: uppercase;
+  color: #fff !important;

[Thomas Greiner, 2018/02/16 16:19:17]

What's the reason for using `!important` here?

+  text-align: center;
+  width: 100%;
+  border-radius: 6px;
+  padding: 1em 0;
+  background: #C70D2C;
+}
+
+.store-buttons
+{
+  width:  100%;
+  display: flex;
+  align-items: center;
+  justify-content: center;
+}
+
+.store-button
+{
+  display: block;
+  width: 180px;
+  height: 58px;
+  border-radius: 6px;
+  background: #000;
+}
+
+.store-button > img 
+{
+  height: 54px;
+}
+
+.applestore-button
+{
+  margin-right: 1em;
+}
+
+[dir="rtl"] .appstore-button
+{
+  margin-right: 0;
+  margin-left: 1em;
+}
+
+@media (max-width: 1280px) 
+{
+  .store-buttons 
+  {
+    flex-direction: column;
+  }
+  
+  .store-button 
+  {
+    width: 100%;
+  }
+  .applestore-button

[Thomas Greiner, 2018/02/16 16:19:16]

Coding style: "Separate rules by new lines."

See https://google.github.io/styleguide/htmlcssguide.html#Rule_Separation

   {
-    width: auto;
-    padding: 20px 0px;
-    border-style: dashed none none;
+    margin: 0 0 1em;
+  }
+}
+
+#installation-status-header > h1
+{
+  font-size: 3em;
+  margin: 0;
+}
+
+
+/*******************************************************************************
+ * #footer
+ ******************************************************************************/
+
+#footer
+{
+  overflow: auto;
+  margin-top: 2em;
+  padding: 2em 0em;
+  color: #ececec;
+  background-color: #292929;
+  font-size: 0.9em;
+}
+
+/* #footer body
+ ******************************************************************************/
+
+#footer h5
+{
+  margin-top: 1em;
+  margin-bottom: 1.5em;
+}
+
+#footer h5:after

[Thomas Greiner, 2018/02/16 16:19:16]

Detail: The standard way to write this is `#footer h5::after`. Unlike Websites,
we don't need to support older browsers who don't understand the standard syntax
yet.

See also https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-elements

+{
+  content: "";
+  display: block;
+  width: 1.25em;
+  height: 0.125em;
+  margin-top: 0.5em;
+  background-color: #ececec;
+}
+
+#footer ul
+{
+  padding: 0em;
+  list-style-type: none;
+}
+
+#footer a
+{
+  color: #ececec;
+}
+
+#footer a:hover,
+#footer a:active,
+#footer a:focus
+{
+  color: #fff;
+  text-decoration: underline;
+}
+
+/* #footer #social-list
+ ******************************************************************************/
+
+#social-list ul
+{
+  /* negative margin canceled out by li margin below */
+  margin: 0em -0.375em;
+}
+
+#social-list li
+{
+  float: left;
+  margin: 0em 0.375em;
+}
+
+[dir="rtl"] #social-list li
+{
+  float: right;
+}
+
+#social-list img
+{
+  height: 2em;
+}
+
+@media(min-width: 1200px)
+{
+  #social-list img
+  {
+    height: 3em;
+  }
+}
+
+/* #footer #footer-legal
+ ******************************************************************************/
+
+#footer-legal
+{
+  margin-top: 1em;
+}
+
+@media(min-width: 1200px)
+{
+  #footer-legal
+  {
+    margin-top: 2em;
+  }
+}
+
+/* #footer #footer-legal #legal-list
+ ******************************************************************************/
+
+#legal-list li
+{
+  float: left;
+}
+
+[dir="rtl"] #legal-list li
+{
+  float: right;
+}
+
+#legal-list li:after
+{
+  margin: 0em 0.375em;
+}
+
+/* IE9+ only */

[Thomas Greiner, 2018/02/16 16:19:19]

This is not relevant for us since we don't support IE9 so let's remove it.

+#legal-list li::after
+{
+  content: "|"
+}
+
+#legal-list li:last-of-type::after
+{
+  content: none;
+}
+
+/* float copyright and legal links left and right on ~desktop */
+@media(min-width: 1200px)
+{
+  #copyright-notice
+  {
+    float: left;
   }
 
-  #donate,
-  .share-buttons
+  [dir="rtl"] #copyright-notice
+  {
+    float: right;
+  }
+
+  #legal-list
   {
-    margin-top: 10px;
+    float: right;
+  }
+
+  [dir="rtl"] #legal-list
+  {
+    float: left;
   }
 }
+
+/* hide all footer links except #social-list on ~mobile */
+@media(max-width: 767px)
+{
+  #footer .column
+  {
+    display: none;
+  }
+
+  /* overriding display:none above */
+  #footer #social-list
+  {
+    display: block;
+  }
+}