Unified Diff: desktop-options.js
Issue 29565799:
Noissue - Load options on DOMContentLoaded rather than jQuery.ready (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set:
Created Oct. 5, 2017, 7:40 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: desktop-options.js |
| =================================================================== |
| --- a/desktop-options.js |
| +++ b/desktop-options.js |
| @@ -181,17 +181,17 @@ |
| }); |
| // Load recommended subscriptions |
| loadRecommendations(); |
| // Show user's filters |
| reloadFilters(); |
| } |
| -$(loadOptions); |
| +$(document).on("DOMContentLoaded", loadOptions); |
|
Sebastian Noack
2017/10/05 19:50:28
Why not avoiding jQuery at all and just use docume
Manish Jethani
2017/10/05 20:10:13
Yes, that makes sense.
Done.
(I've also moved it
|
| function convertSpecialSubscription(subscription) |
| { |
| for (let filter of subscription.filters) |
| { |
| if (whitelistedDomainRegexp.test(filter.text)) |
| appendToListBox("excludedDomainsBox", RegExp.$1); |
| else |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
