Side by Side Diff: flake8-eyeo/tests/A103.py
Issue 29565854:
Noissue - Improved accuracy of evaluated expressions for A103 and A207 (Closed)
Patch Set: Changed behavior of A207
Created Oct. 11, 2017, 6:25 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« flake8-eyeo/flake8_eyeo.py ('K')
|
« flake8-eyeo/flake8_eyeo.py ('k')
|
flake8-eyeo/tests/A207.py » ('j')
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 def compare_int_like_yoda(x): | 1 def compare_int_like_yoda(x): |
| 2 # * A103 | 2 # * A103 |
| 3 return 1 == x | 3 return 1 == x |
| 4 | 4 |
| 5 | 5 |
| 6 def compare_string_like_yoda(x): | 6 def compare_string_like_yoda(x): |
| 7 # * A103 | 7 # * A103 |
| 8 return 'foo' == x | 8 return 'foo' == x |
| 9 | 9 |
| 10 | 10 |
| 11 def compare_none_like_yoda(x): | 11 def compare_none_like_yoda(x): |
| 12 # * A103 | 12 # * A103 |
| 13 return None is x | 13 return None is x |
| 14 | 14 |
| 15 | 15 |
| 16 def compare_tuple_like_yoda(x): | 16 def compare_tuple_like_yoda(x): |
| 17 # * A103 | 17 # * A103 |
| 18 return (1, 'foo') == x | 18 return (1, 'foo') == x |
| 19 | 19 |
| 20 | 20 |
| 21 def compare_literals(): | 21 def compare_literals(): |
| 22 return (1, 'foo') == (2, 'bar') | 22 return (1, 'foo') == (2, 'bar') |
| 23 | 23 |
| 24 | 24 |
| 25 def compare_variables(a, b, c, d): | 25 def compare_variables(a, b, c, d): |
| 26 return (a, b) == (c, d) or a == b | 26 return (a, b) == (c, d) or a == b |
| 27 | |
| 28 | |
| 29 def compare_builtin(x): | |
| 30 return dir == x | |
| OLD | NEW |
« flake8-eyeo/flake8_eyeo.py ('K')
|
« flake8-eyeo/flake8_eyeo.py ('k')
|
flake8-eyeo/tests/A207.py » ('j')
|
no next file with comments »
