Issue 5803 - rename desktop options page to desktop-options.*

See -> https://codereview.adblockplus.org/29565838/diff/29565851/metadata.gecko-webext#newcode15

[saroyanm, 2017-10-05 22:36:13]

I do remember that we have discussed this, but I don't remember why exactly we
decided not to rename to the desktop-options.*

https://codereview.adblockplus.org/29565861/diff/29565867/desktop-options.html
File desktop-options.html (right):

https://codereview.adblockplus.org/29565861/diff/29565867/desktop-options.htm...
desktop-options.html:29: <script src="desktop-options.js"></script>
I need to rename files in order to load same script from the built version.

[Thomas Greiner, 2017-10-06 12:21:15]

Those changes do not correspond to the changes we made when we renamed it
previously from new-options.html to options.html (see
https://codereview.adblockplus.org/29559679/).

[saroyanm, 2017-10-06 16:57:19]

On 2017/10/06 12:21:15, Thomas Greiner wrote:
> Those changes do not correspond to the changes we made when we renamed it
> previously from new-options.html to options.html (see
> https://codereview.adblockplus.org/29559679/).

Done, new patch uploaded.

[Thomas Greiner, 2017-10-06 17:05:50]

https://codereview.adblockplus.org/29565861/diff/29567826/background.js
File background.js (left):

https://codereview.adblockplus.org/29565861/diff/29567826/background.js#oldco...
background.js:403: if (!/\/(mobile-)?options\.html\b/.test(top.location.href))
Detail: We can keep the `\b` at the end of the regex unless it's causing issues.

https://codereview.adblockplus.org/29565861/diff/29567826/background.js
File background.js (right):

https://codereview.adblockplus.org/29565861/diff/29567826/background.js#newco...
background.js:404: window.open("options.html", "_blank");
There is no options.html in the adblockplusui repository so we need to rename it
to desktop-options.html here too.

[saroyanm, 2017-10-06 17:28:27]

https://codereview.adblockplus.org/29565861/diff/29567826/background.js
File background.js (left):

https://codereview.adblockplus.org/29565861/diff/29567826/background.js#oldco...
background.js:403: if (!/\/(mobile-)?options\.html\b/.test(top.location.href))
On 2017/10/06 17:05:50, Thomas Greiner wrote:
> Detail: We can keep the `\b` at the end of the regex unless it's causing
issues.

Done.

https://codereview.adblockplus.org/29565861/diff/29567826/background.js
File background.js (right):

https://codereview.adblockplus.org/29565861/diff/29567826/background.js#newco...
background.js:404: window.open("options.html", "_blank");
On 2017/10/06 17:05:50, Thomas Greiner wrote:
> There is no options.html in the adblockplusui repository so we need to rename
it
> to desktop-options.html here too.
done.

[Thomas Greiner, 2017-10-06 18:04:48]

LGTM