Unified Diff: background.js
Issue 29565861:
Issue 5803 - rename desktop options page to desktop-options.* (Closed)
Patch Set:
Created Oct. 6, 2017, 4:55 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« README.md ('k')
|
desktop-options.html » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: background.js |
| =================================================================== |
| --- a/background.js |
| +++ b/background.js |
| @@ -400,7 +400,7 @@ |
| modules.options = { |
| showOptions(callback) |
| { |
| - if (!/\/(mobile-)?options\.html\b/.test(top.location.href)) |
|
Thomas Greiner
2017/10/06 17:05:50
Detail: We can keep the `\b` at the end of the reg
saroyanm
2017/10/06 17:28:27
Done.
|
| + if (!/\/(?:mobile|desktop)-options\.html/.test(top.location.href)) |
| window.open("options.html", "_blank"); |
|
Thomas Greiner
2017/10/06 17:05:50
There is no options.html in the adblockplusui repo
saroyanm
2017/10/06 17:28:27
done.
|
| if (callback) |
« no previous file with comments
|
« README.md ('k')
|
desktop-options.html » ('j')
|
no next file with comments »
