Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1830)

Issue 29567642: Issue 5414 - Add style guide page to help.eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by ire
Modified:
3 days, 13 hours ago
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/help.eyeo.com
Visibility:
Public.

Description

Issue 5414 - Add style guide page to help.eyeo.com

Patch Set 1 #

Patch Set 2 : Update default.tmpl to include .container.content classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M templates/article.tmpl View 1 2 chunks +5 lines, -1 line 0 comments Download
M templates/default.tmpl View 1 1 chunk +3 lines, -5 lines 0 comments Download
M templates/product-home.tmpl View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 18
ire
2 weeks ago (2017-10-06 10:28:17 UTC) #1
juliandoucette
Exception: Failed to resolve include styleguide/typography/index on page styleguide/developer
1 week, 4 days ago (2017-10-09 22:43:32 UTC) #2
juliandoucette
On 2017/10/09 22:43:32, juliandoucette wrote: > Exception: Failed to resolve include styleguide/typography/index on page > ...
1 week, 4 days ago (2017-10-09 22:44:22 UTC) #3
juliandoucette
I think that we can inherit these pages from website-defaults instead? 1. Place these pages ...
1 week, 4 days ago (2017-10-09 22:47:25 UTC) #4
ire
On 2017/10/09 22:44:22, juliandoucette wrote: > On 2017/10/09 22:43:32, juliandoucette wrote: > > Exception: Failed ...
1 week, 2 days ago (2017-10-11 17:10:49 UTC) #5
ire
On 2017/10/09 22:47:25, juliandoucette wrote: > I think that we can inherit these pages from ...
1 week, 2 days ago (2017-10-11 17:11:09 UTC) #6
juliandoucette
On 2017/10/11 17:11:09, ire wrote: > Good idea. I've created a ticket to handle this ...
1 week, 2 days ago (2017-10-11 17:54:34 UTC) #7
ire
On 2017/10/11 17:54:34, juliandoucette wrote: > On 2017/10/11 17:11:09, ire wrote: > > Good idea. ...
1 week, 1 day ago (2017-10-12 11:05:47 UTC) #8
juliandoucette
On 2017/10/12 11:05:47, ire wrote: > I think I misunderstood how this would work. Are ...
1 week, 1 day ago (2017-10-12 11:10:55 UTC) #9
ire
On 2017/10/12 11:10:55, juliandoucette wrote: > On 2017/10/12 11:05:47, ire wrote: > > I think ...
1 week, 1 day ago (2017-10-12 11:29:39 UTC) #10
juliandoucette
On 2017/10/12 11:29:39, ire wrote: > On 2017/10/12 11:10:55, juliandoucette wrote: > > On 2017/10/12 ...
1 week, 1 day ago (2017-10-12 13:05:32 UTC) #11
ire
On 2017/10/12 13:05:32, juliandoucette wrote: > On 2017/10/12 11:29:39, ire wrote: > > On 2017/10/12 ...
1 week, 1 day ago (2017-10-12 13:59:48 UTC) #12
juliandoucette
On 2017/10/12 13:59:48, ire wrote: > Not really. the .container.content is only used on article ...
1 week ago (2017-10-13 12:42:08 UTC) #13
juliandoucette
On 2017/10/13 12:42:08, juliandoucette wrote: > I think that this is a problem with the ...
1 week ago (2017-10-13 12:46:07 UTC) #14
juliandoucette
On 2017/10/13 12:46:07, juliandoucette wrote: > Or, for the sake of consistency, we should consider ...
1 week ago (2017-10-13 12:47:32 UTC) #15
ire
> I think that this is a problem with the default template. I think that, ...
4 days, 14 hours ago (2017-10-16 14:31:43 UTC) #16
ire
On 2017/10/16 14:31:43, ire wrote: > > I think that this is a problem with ...
4 days, 14 hours ago (2017-10-16 14:37:29 UTC) #17
juliandoucette
3 days, 17 hours ago (2017-10-17 11:16:44 UTC) #18
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5