Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(765)

Issue 29567648: Issue 4248 - Add codestyle check

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by anton
Modified:
1 day, 5 hours ago
CC:
René Jeschke, Felix Dahlke, sergei
Visibility:
Public.

Description

Issue 4248 - Add codestyle check Changes for 'codingtools' repository

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+954 lines, -0 lines) Patch
A checkstyle/java/res/header.txt View 1 chunk +16 lines, -0 lines 3 comments Download
A checkstyle/java/rules/eyeo_production_checks.xml View 1 chunk +185 lines, -0 lines 1 comment Download
A checkstyle/java/rules/eyeo_test_checks.xml View 1 chunk +188 lines, -0 lines 0 comments Download
A checkstyle/java/rules/google_checks.xml View 1 chunk +213 lines, -0 lines 0 comments Download
A checkstyle/java/rules/mozilla_checks.xml View 1 chunk +172 lines, -0 lines 0 comments Download
A checkstyle/java/rules/sun_checks.xml View 1 chunk +180 lines, -0 lines 0 comments Download

Messages

Total messages: 10
anton
https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt File checkstyle/java/res/header.txt (right): https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt#newcode3 checkstyle/java/res/header.txt:3: * Copyright (C) 2006-present eyeo GmbH Note i've updated ...
2 months, 1 week ago (2017-10-06 11:29:53 UTC) #1
jens
On 2017/10/06 11:29:53, anton wrote: > https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt > File checkstyle/java/res/header.txt (right): > > https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt#newcode3 > ...
2 months ago (2017-10-11 12:18:27 UTC) #2
jens
https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt File checkstyle/java/res/header.txt (right): https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt#newcode11 checkstyle/java/res/header.txt:11: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See ...
2 months ago (2017-10-11 12:18:34 UTC) #3
anton
https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt File checkstyle/java/res/header.txt (right): https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt#newcode11 checkstyle/java/res/header.txt:11: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See ...
2 months ago (2017-10-11 12:22:27 UTC) #4
anton
On 2017/10/11 12:22:27, anton wrote: > https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt > File checkstyle/java/res/header.txt (right): > > https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt#newcode11 > ...
2 months ago (2017-10-11 12:23:51 UTC) #5
jens
On 2017/10/11 12:22:27, anton wrote: > https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt > File checkstyle/java/res/header.txt (right): > > https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt#newcode11 > ...
2 months ago (2017-10-11 12:24:34 UTC) #6
Vasily Kuznetsov
On 2017/10/11 12:24:34, jens wrote: > On 2017/10/11 12:22:27, anton wrote: > > > https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/res/header.txt ...
2 months ago (2017-10-11 15:32:43 UTC) #7
jens
On 2017/10/11 15:32:43, Vasily Kuznetsov wrote: > On 2017/10/11 12:24:34, jens wrote: > > On ...
2 months ago (2017-10-12 07:53:33 UTC) #8
diegocarloslima
https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/rules/eyeo_production_checks.xml File checkstyle/java/rules/eyeo_production_checks.xml (right): https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/rules/eyeo_production_checks.xml#newcode98 checkstyle/java/rules/eyeo_production_checks.xml:98: <!-- See http://checkstyle.sf.net/config_imports.html --> I know that the comments ...
1 month, 4 weeks ago (2017-10-16 12:31:15 UTC) #9
diegocarloslima
1 day, 5 hours ago (2017-12-13 11:17:19 UTC) #10
On 2017/10/16 12:31:15, diegocarloslima wrote:
>
https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/rul...
> File checkstyle/java/rules/eyeo_production_checks.xml (right):
> 
>
https://codereview.adblockplus.org/29567648/diff/29567649/checkstyle/java/rul...
> checkstyle/java/rules/eyeo_production_checks.xml:98: <!-- See
> http://checkstyle.sf.net/config_imports.html -->
> I know that the comments here are based on sun_checks.xml, but I just think
that
> would be better to just close the comments without adding extra spaces to
align
> them, since they can eventually get misaligned when the comments changes, like
> here.

LGTM, with a minor note regarding comments
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5