Issue 5835 - Add some notification related message handlers

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 10 matching lines @@
 
 (function(global)
 {
   const {port} = require("messaging");
   const {Prefs} = require("prefs");
   const {Utils} = require("utils");
   const {FilterStorage} = require("filterStorage");
   const {FilterNotifier} = require("filterNotifier");
   const {defaultMatcher} = require("matcher");
   const {Notification: NotificationStorage} = require("notification");
   const {getActiveNotification, shouldDisplay} = require("notificationHelper");

[Sebastian Noack, 2017/10/08 01:35:35]

You have to implement mocks for these APIs in background.js, otherwise this line
will throw an error when running any UI page standalone with the test server in
adblockplusui. However, for now, the mock implementation can probably be noop,
as there is no code that will use it, hence it cannot even be tested, before
there is a popup implementation inside adblockplusui. Yet, it still needs to
exist at least, otherwise undefined will be attempted to restructured here.

[kzar, 2017/10/08 10:08:15]

Whoops, Done.

 
   const {Filter, BlockingFilter, RegExpFilter} = require("filterClasses");
   const {Synchronizer} = require("synchronizer");
 
   const info = require("info");
   const {
     Subscription,
     DownloadableSubscription,
     SpecialSubscription
   } = require("subscriptionClasses");
@@ skipping 303 matching lines @@
 
   port.on("notifications.get", (message, sender) =>
   {
     let notification = getActiveNotification();
 
     if (!notification ||
         "displayMethod" in message &&
         !shouldDisplay(message.displayMethod, notification.type))
       return;
 
-    notification.texts = NotificationStorage.getLocalizedTexts(notification,

[Sebastian Noack, 2017/10/08 01:35:35]

It seems inappropriate to modify the original object. That way this property
will also be available to other code, while we just want to pass it to the UI.

[kzar, 2017/10/08 10:08:15]

Good point, Done.

-                                                               message.locale);
-    return notification;
+    let texts = NotificationStorage.getLocalizedTexts(notification,
+                                                      message.locale);
+    return Object.assign({texts}, notification);
   });
 
   port.on("subscriptions.add", (message, sender) =>
   {
     let subscription = Subscription.fromURL(message.url);
     if (message.confirm)
     {
       if ("title" in message)
         subscription.title = message.title;
       if ("homepage" in message)
@@ skipping 61 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);