Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: background.js

Issue 29567743: Issue 5835 - Add some notification related message handlers (Closed)
Left Patch Set: Addressed Sebastian's feedback Created Oct. 8, 2017, 10:07 a.m.
Right Patch Set: Addressed nits Created Oct. 9, 2017, 11:12 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | messageResponder.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 if (index == -1) 134 if (index == -1)
135 categories.push(category); 135 categories.push(category);
136 else 136 else
137 categories.splice(index, 1); 137 categories.splice(index, 1);
138 modules.prefs.Prefs.notifications_ignoredcategories = categories; 138 modules.prefs.Prefs.notifications_ignoredcategories = categories;
139 } 139 }
140 } 140 }
141 }; 141 };
142 142
143 modules.notificationHelper = { 143 modules.notificationHelper = {
144 getActiveNotification() { }, 144 getActiveNotification()
145 shouldDisplay() { return true; } 145 {
Thomas Greiner 2017/10/09 10:52:59 Coding style: "Opening braces always go on their o
kzar 2017/10/09 11:13:51 Done.
146 },
147 shouldDisplay()
148 {
149 return true;
150 }
146 }; 151 };
147 152
148 let subscriptionServer = "https://easylist-downloads.adblockplus.org"; 153 let subscriptionServer = "https://easylist-downloads.adblockplus.org";
149 let subscriptionDetails = { 154 let subscriptionDetails = {
150 [`${subscriptionServer}/easylistgermany+easylist.txt`]: { 155 [`${subscriptionServer}/easylistgermany+easylist.txt`]: {
151 title: "EasyList Germany+EasyList", 156 title: "EasyList Germany+EasyList",
152 installed: true 157 installed: true
153 }, 158 },
154 [`${subscriptionServer}/exceptionrules.txt`]: { 159 [`${subscriptionServer}/exceptionrules.txt`]: {
155 title: "Allow non-intrusive advertising", 160 title: "Allow non-intrusive advertising",
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 }, 600 },
596 filter: { 601 filter: {
597 text: "||example.com/some-annoying-popup$popup", 602 text: "||example.com/some-annoying-popup$popup",
598 whitelisted: false, 603 whitelisted: false,
599 userDefined: true, 604 userDefined: true,
600 subscription: null 605 subscription: null
601 } 606 }
602 }); 607 });
603 }); 608 });
604 }()); 609 }());
LEFTRIGHT

Powered by Google App Engine
This is Rietveld