Issue 5835 - Add some notification related message handlers

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 123 matching lines @@
         if (index == -1)
           categories.push(category);
         else
           categories.splice(index, 1);
         modules.prefs.Prefs.notifications_ignoredcategories = categories;
       }
     }
   };
 
   modules.notificationHelper = {
-    getActiveNotification() { },
-    shouldDisplay() { return true; }

[Thomas Greiner, 2017/10/09 10:52:59]

Coding style: "Opening braces always go on their own line."

Alternatively, you could use an arrow function instead.

[kzar, 2017/10/09 11:13:51]

Done.

+    getActiveNotification()
+    {
+    },
+    shouldDisplay()
+    {
+      return true;
+    }
   };
 
   let subscriptionServer = "https://easylist-downloads.adblockplus.org";
   let subscriptionDetails = {
     [`${subscriptionServer}/easylistgermany+easylist.txt`]: {
       title: "EasyList Germany+EasyList",
       installed: true
     },
     [`${subscriptionServer}/exceptionrules.txt`]: {
       title: "Allow non-intrusive advertising",
@@ skipping 439 matching lines @@
       },
       filter: {
         text: "||example.com/some-annoying-popup$popup",
         whitelisted: false,
         userDefined: true,
         subscription: null
       }
     });
   });
 }());