Issue 5835 - Add some notification related message handlers

messageResponder.js

Index: messageResponder.js
diff --git a/messageResponder.js b/messageResponder.js
index b8516d3b32f3d3a94fba8a4cfbc5b89a93090bdb..044673d90780145e88a1180560a66286450b2765 100644
--- a/messageResponder.js
+++ b/messageResponder.js
@@ -28,6 +28,7 @@
   const {FilterNotifier} = require("filterNotifier");
   const {defaultMatcher} = require("matcher");
   const {Notification: NotificationStorage} = require("notification");
+  const {getActiveNotification, shouldDisplay} = require("notificationHelper");

[Sebastian Noack, 2017/10/08 01:35:35]

You have to implement mocks for these APIs in background.js, otherwise this line
will throw an error when running any UI page standalone with the test server in
adblockplusui. However, for now, the mock implementation can probably be noop,
as there is no code that will use it, hence it cannot even be tested, before
there is a popup implementation inside adblockplusui. Yet, it still needs to
exist at least, otherwise undefined will be attempted to restructured here.

[kzar, 2017/10/08 10:08:15]

Whoops, Done.

 
   const {Filter, BlockingFilter, RegExpFilter} = require("filterClasses");
   const {Synchronizer} = require("synchronizer");
@@ -342,6 +343,20 @@
     return Prefs[message.key] = !Prefs[message.key];
   });
 
+  port.on("notifications.get", (message, sender) =>
+  {
+    let notification = getActiveNotification();
+
+    if (!notification ||
+        "displayMethod" in message &&
+        !shouldDisplay(message.displayMethod, notification.type))
+      return;
+
+    notification.texts = NotificationStorage.getLocalizedTexts(notification,

[Sebastian Noack, 2017/10/08 01:35:35]

It seems inappropriate to modify the original object. That way this property
will also be available to other code, while we just want to pass it to the UI.

[kzar, 2017/10/08 10:08:15]

Good point, Done.

+                                                               message.locale);
+    return notification;
+  });
+
   port.on("subscriptions.add", (message, sender) =>
   {
     let subscription = Subscription.fromURL(message.url);