Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: popup.js

Issue 29567749: Issue 5593 - Use messaging for the popup's notification code (Closed)
Left Patch Set: Use notifications.get message, addressed Manish's feedback Created Oct. 6, 2017, 8:04 p.m.
Right Patch Set: Rebased Created Oct. 9, 2017, 4:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « notification.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 let tab = null; 20 let tab = null;
21 21
22 function getPref(key, callback) 22 function getPref(key, callback)
23 { 23 {
24 chrome.runtime.sendMessage({type: "prefs.get", key}, callback); 24 chrome.runtime.sendMessage({type: "prefs.get", key}, callback);
25 }
26
27 function setPref(key, value, callback)
28 {
29 chrome.runtime.sendMessage({type: "prefs.set", key, value}, callback);
25 } 30 }
26 31
27 function togglePref(key, callback) 32 function togglePref(key, callback)
28 { 33 {
29 chrome.runtime.sendMessage({type: "prefs.toggle", key}, callback); 34 chrome.runtime.sendMessage({type: "prefs.toggle", key}, callback);
30 } 35 }
31 36
32 function isPageWhitelisted(callback) 37 function isPageWhitelisted(callback)
33 { 38 {
34 chrome.runtime.sendMessage({type: "filters.isWhitelisted", tab}, callback); 39 chrome.runtime.sendMessage({type: "filters.isWhitelisted", tab}, callback);
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 180
176 function toggleCollapse(event) 181 function toggleCollapse(event)
177 { 182 {
178 let collapser = event.currentTarget; 183 let collapser = event.currentTarget;
179 let collapsible = document.getElementById(collapser.dataset.collapsible); 184 let collapsible = document.getElementById(collapser.dataset.collapsible);
180 collapsible.classList.toggle("collapsed"); 185 collapsible.classList.toggle("collapsed");
181 togglePref(collapser.dataset.option); 186 togglePref(collapser.dataset.option);
182 } 187 }
183 188
184 document.addEventListener("DOMContentLoaded", onLoad, false); 189 document.addEventListener("DOMContentLoaded", onLoad, false);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld