Issue 5593 - Use messaging for the popup's notification code

notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 74 matching lines @@
 
       messageElement.addEventListener("click", event =>
       {
         let link = event.target;
         while (link && link != messageElement && link.localName != "a")
           link = link.parentNode;
         if (!link)
           return;
         event.preventDefault();
         event.stopPropagation();
-        ext.pages.open(link.href);

[Sebastian Noack, 2017/10/09 15:40:17]

ext.pages.open() doesn't exist anymore:
https://hg.adblockplus.org/adblockpluschrome/rev/faf3d97ad473

[kzar, 2017/10/09 15:47:07]

Done.

+        chrome.tabs.create({url: link.href});
       });
     });
 
     let notificationElement = document.getElementById("notification");
     notificationElement.className = notification.type;
     notificationElement.hidden = false;
     notificationElement.addEventListener("click", event =>
     {
       if (event.target.id == "notification-close")
         notificationElement.classList.add("closing");
       else if (event.target.id == "notification-optout" ||
                event.target.id == "notification-hide")
       {
         if (event.target.id == "notification-optout")
           setPref("notifications_ignoredcategories", true);
 
         notificationElement.hidden = true;
         notification.onClicked();
       }
     }, true);
   });
 }, false);