Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: stats.js

Issue 29567798: Noissue - Replace ext.pages.open with tabs.create (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Left Patch Set: Created Oct. 6, 2017, 3:16 p.m.
Right Patch Set: Remove ext.pages.open implementation Created Oct. 8, 2017, 9:45 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « notification.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 /* global i18n, getPref, togglePref */ 18 /* global i18n, getPref, togglePref */
19 19
20 "use strict"; 20 "use strict";
21 21
22 (function() 22 (function()
23 { 23 {
24 const {require} = ext.backgroundPage.getWindow();
25
24 const {FilterNotifier} = require("filterNotifier"); 26 const {FilterNotifier} = require("filterNotifier");
25 27
26 let currentTab; 28 let currentTab;
27 const shareURL = "https://adblockplus.org/"; 29 const shareURL = "https://adblockplus.org/";
28 30
29 let messageMark = {}; 31 let messageMark = {};
30 let shareLinks = { 32 let shareLinks = {
31 facebook: ["https://www.facebook.com/dialog/feed", { 33 facebook: ["https://www.facebook.com/dialog/feed", {
32 app_id: "475542399197328", 34 app_id: "475542399197328",
33 link: shareURL, 35 link: shareURL,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 { 145 {
144 document.getElementById("show-iconnumber").setAttribute( 146 document.getElementById("show-iconnumber").setAttribute(
145 "aria-checked", showStatsInIcon 147 "aria-checked", showStatsInIcon
146 ); 148 );
147 }); 149 });
148 } 150 }
149 151
150 document.addEventListener("DOMContentLoaded", onLoad, false); 152 document.addEventListener("DOMContentLoaded", onLoad, false);
151 window.addEventListener("unload", onUnload, false); 153 window.addEventListener("unload", onUnload, false);
152 }()); 154 }());
LEFTRIGHT

Powered by Google App Engine
This is Rietveld