Unified Diff: lib/subscriptionInit.js
Issue 29567798:
Noissue - Replace ext.pages.open with tabs.create (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set:
Created Oct. 6, 2017, 3:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/notificationHelper.js ('k')
|
notification.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/subscriptionInit.js |
| =================================================================== |
| --- a/lib/subscriptionInit.js |
| +++ b/lib/subscriptionInit.js |
| @@ -200,17 +200,17 @@ |
| { |
| FilterStorage.addSubscription(subscription); |
| if (subscription instanceof DownloadableSubscription && |
| !subscription.lastDownload) |
| Synchronizer.execute(subscription); |
| } |
| if (firstRun && !Prefs.suppress_first_run_page) |
| - ext.pages.open(ext.getURL("firstRun.html")); |
| + chrome.tabs.create({url: ext.getURL("firstRun.html")}); |
| initNotifications(); |
| } |
| Promise.all([FilterNotifier.once("load"), |
| Prefs.untilLoaded]).then(detectFirstRun) |
| .then(getSubscriptions) |
| .then(finishInitialization); |
« no previous file with comments
|
« lib/notificationHelper.js ('k')
|
notification.js » ('j')
|
no next file with comments »
