ext/background.js - Issue 29567798: Noissue - Replace ext.pages.open with tabs.create

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/background.js

Issue 29567798: Noissue - Replace ext.pages.open with tabs.create (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Remove ext.pages.open implementation Created Oct. 8, 2017, 9:45 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/background.js

===================================================================

--- a/ext/background.js

+++ b/ext/background.js

@@ -116,20 +116,16 @@

callback(new Page(openedTab));

}

};

chrome.tabs.onUpdated.addListener(onUpdated);

};

}

ext.pages = {

- open(url, callback)

- {

- chrome.tabs.create({url}, callback && afterTabLoaded(callback));

- },

query(info, callback)

{

let rawInfo = {};

for (let property in info)

{

switch (property)

{

case "active":

« no previous file with comments | « no previous file | lib/notificationHelper.js » ('j') | no next file with comments »