Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29567856: Issue 5842 - Add Spanish and Vietnamese filter lists string (Closed)

Created:
Oct. 6, 2017, 9:35 p.m. by saroyanm
Modified:
Oct. 9, 2017, 4:55 p.m.
Reviewers:
ire
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 5842 - Add Spanish and Vietnamese filter lists string

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M locale/en-US/desktop-options.json View 2 chunks +8 lines, -0 lines 0 comments Download
M subscriptions.xml View 6 chunks +27 lines, -13 lines 2 comments Download

Messages

Total messages: 2
saroyanm
@Ire can you please have a look when you have a chance. https://codereview.adblockplus.org/29567856/diff/29567857/subscriptions.xml File subscriptions.xml ...
Oct. 6, 2017, 9:37 p.m. (2017-10-06 21:37:51 UTC) #1
ire
Oct. 9, 2017, 4:48 p.m. (2017-10-09 16:48:16 UTC) #2
Thanks Manvel. LGTM

https://codereview.adblockplus.org/29567856/diff/29567857/subscriptions.xml
File subscriptions.xml (right):

https://codereview.adblockplus.org/29567856/diff/29567857/subscriptions.xml#n...
subscriptions.xml:24: homepage="https://easylist.to/"
On 2017/10/06 21:37:51, saroyanm wrote:
> I copied, updated version of subscriptions.xml from core ->
>
https://hg.adblockplus.org/adblockpluscore/file/tip/chrome/content/ui/subscri...
> 
> 
> This is the version which is being used in the production.

Acknowledged.

Powered by Google App Engine
This is Rietveld