Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1303)

Issue 29568555: Issue 5723 - Implement new abp.org content style guide (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by juliandoucette
Modified:
1 year, 9 months ago
Reviewers:
ire
Base URL:
https://bitbucket.org/adblockplus/adblockplus.org
Visibility:
Public.

Description

Issue 5723 - Implement new abp.org content style guide

Patch Set 1 #

Total comments: 21

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -112 lines) Patch
A static/css/defaults.css View 1 1 chunk +403 lines, -0 lines 0 comments Download
M static/css/index.css View 2 chunks +6 lines, -1 line 0 comments Download
M static/css/index-mobile.css View 1 chunk +0 lines, -2 lines 0 comments Download
M static/css/main.css View 1 3 chunks +21 lines, -108 lines 0 comments Download
M templates/default.tmpl View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12
juliandoucette
1 year, 9 months ago (2017-10-07 15:33:15 UTC) #1
juliandoucette
Ready for review. I think you should address this before header and footer if you ...
1 year, 9 months ago (2017-10-07 15:37:25 UTC) #2
juliandoucette
If you think that this looks good then I will rebase away website-defaults from main.css ...
1 year, 9 months ago (2017-10-07 15:38:15 UTC) #3
juliandoucette
Note: I didn't set the html font-size. But I did set the heading sizes relative ...
1 year, 9 months ago (2017-10-07 15:44:37 UTC) #4
juliandoucette
Added notes. https://codereview.adblockplus.org/29568555/diff/29568556/static/css/index-mobile.css File static/css/index-mobile.css (left): https://codereview.adblockplus.org/29568555/diff/29568556/static/css/index-mobile.css#oldcode4 static/css/index-mobile.css:4: margin-left: 0; This prevented the mobile content ...
1 year, 9 months ago (2017-10-07 15:50:08 UTC) #5
ire
On 2017/10/07 15:37:25, juliandoucette wrote: > Ready for review. I think you should address this ...
1 year, 9 months ago (2017-10-09 11:35:50 UTC) #6
ire
On 2017/10/07 15:44:37, juliandoucette wrote: > Note: > > I didn't set the html font-size. ...
1 year, 9 months ago (2017-10-09 12:28:31 UTC) #7
ire
Thanks. Comments below. https://codereview.adblockplus.org/29568555/diff/29568556/static/css/defaults.css File static/css/defaults.css (right): https://codereview.adblockplus.org/29568555/diff/29568556/static/css/defaults.css#newcode16 static/css/defaults.css:16: * along with website-defaults. If not, ...
1 year, 9 months ago (2017-10-09 12:28:49 UTC) #8
juliandoucette
New PatchSet :) https://codereview.adblockplus.org/29568555/diff/29568556/static/css/defaults.css File static/css/defaults.css (right): https://codereview.adblockplus.org/29568555/diff/29568556/static/css/defaults.css#newcode16 static/css/defaults.css:16: * along with website-defaults. If not, ...
1 year, 9 months ago (2017-10-09 23:28:54 UTC) #9
ire
LGTM https://codereview.adblockplus.org/29568555/diff/29568556/static/css/defaults.css File static/css/defaults.css (right): https://codereview.adblockplus.org/29568555/diff/29568556/static/css/defaults.css#newcode102 static/css/defaults.css:102: tr, th, td { On 2017/10/09 23:28:53, juliandoucette ...
1 year, 9 months ago (2017-10-10 07:48:44 UTC) #10
juliandoucette
Issue 5723 - Implement new abp.org content style guide
1 year, 9 months ago (2017-10-10 10:59:42 UTC) #11
juliandoucette
1 year, 9 months ago (2017-10-10 11:00:03 UTC) #12

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5