Issue 29569566: Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 (sitescripts)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29569566: Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 (sitescripts) (Closed)

Created:
Oct. 8, 2017, 6:02 p.m. by Sebastian Noack

Modified:
Oct. 10, 2017, 4:59 a.m.

Reviewers:
Vasily Kuznetsov

CC:
tlucas

Visibility:
Public.

Description

Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 (sitescripts)

Patch Set 1 #

Created: Oct. 8, 2017, 6:02 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -4 lines)			Patch
M	sitescripts/content_blocker_lists/bin/generate_lists.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/crawler/bin/import_sites.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/docs/bin/generate_docs.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/extensions/bin/updateRecommendations.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/extensions/bin/updateUpdateManifests.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/extensions/web/downloads.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/management/bin/generateHgAuth.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/management/bin/generateNotifications.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/management/bin/installChanges.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/management/bin/start_services.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/notifications/test/notification.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/reports/bin/mailDigests.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/reports/bin/parseNewReports.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/reports/bin/processReports.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/reports/bin/removeOldReports.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/reports/bin/removeOldUsers.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/reports/bin/updateDigests.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/reports/bin/updateSubscriptionList.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/stats/bin/logprocessor.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/stats/bin/pagegenerator.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/stats/common.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/stats/test/common.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/stats/test/logprocessor.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/subscriptions/bin/generateReport.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/subscriptions/bin/processTemplate.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/subscriptions/bin/updateStatusPage.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/subscriptions/bin/updateSubscriptionDownloads.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/subscriptions/combineSubscriptions.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/templateFilters.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/urlfixer/bin/forceDomains.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/urlfixer/bin/topDomains.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/utils.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sitescripts/web.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tox.ini	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

The whitespace changes were due to the flake8 update, as flake8 2 didn't log an ...

Oct. 8, 2017, 6:16 p.m. (2017-10-08 18:16:26 UTC) #1

Vasily Kuznetsov

Oct. 9, 2017, 8:32 p.m. (2017-10-09 20:32:03 UTC) #2

On 2017/10/08 18:16:26, Sebastian Noack wrote:
> The whitespace changes were due to the flake8 update, as flake8 2 didn't log
an
> E305 there. All changes outside of tox.ini were auto-generated with `autopep8
-i
> --select=E305`.

LGTM

Expand All Messages | Collapse All Messages