Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29569602: Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 (cms) (Closed)

Created:
Oct. 8, 2017, 6:09 p.m. by Sebastian Noack
Modified:
Oct. 10, 2017, 4:59 a.m.
Reviewers:
Vasily Kuznetsov
CC:
tlucas, Jon Sonesen
Visibility:
Public.

Description

Noissue - Replace flake8-putty with flake8-per-file-ignores, update to flake8 3 (cms)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M cms/bin/generate_static_pages.py View 1 chunk +1 line, -0 lines 0 comments Download
M cms/bin/test_server.py View 1 chunk +1 line, -0 lines 0 comments Download
M cms/bin/translate.py View 1 chunk +1 line, -0 lines 0 comments Download
M cms/converters.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tox.ini View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
The whitespace changes were due to the flake8 update, as flake8 2 didn't log an ...
Oct. 8, 2017, 6:15 p.m. (2017-10-08 18:15:13 UTC) #1
Vasily Kuznetsov
Oct. 9, 2017, 8:28 p.m. (2017-10-09 20:28:19 UTC) #2
On 2017/10/08 18:15:13, Sebastian Noack wrote:
> The whitespace changes were due to the flake8 update, as flake8 2 didn't log
an
> E305 there. All changes outside of tox.ini were auto-generated with `autopep8
-i
> --select=E305`.

At first I thought "what are these whitespace changes doing in this review?"
Then I read your comment and I agree with how you handled more strict behavior
of flake8 3.

LGTM

Powered by Google App Engine
This is Rietveld