Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/filterComposer.js

Issue 29569615: Noissue - Replace ext.pages.query with tabs.query (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Oct. 8, 2017, 11:37 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ext/background.js ('k') | lib/icon.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 !filter && Prefs.shouldShowBlockElementMenu && readyPages.has(page)) 188 !filter && Prefs.shouldShowBlockElementMenu && readyPages.has(page))
189 { 189 {
190 page.contextMenus.create(contextMenuItem); 190 page.contextMenus.create(contextMenuItem);
191 } 191 }
192 } 192 }
193 193
194 FilterNotifier.on("page.WhitelistingStateRevalidate", updateContextMenu); 194 FilterNotifier.on("page.WhitelistingStateRevalidate", updateContextMenu);
195 195
196 Prefs.on("shouldShowBlockElementMenu", () => 196 Prefs.on("shouldShowBlockElementMenu", () =>
197 { 197 {
198 ext.pages.query({}, pages => 198 chrome.tabs.query({}, tabs =>
199 { 199 {
200 for (let page of pages) 200 for (let tab of tabs)
201 updateContextMenu(page); 201 updateContextMenu(new ext.Page(tab));
202 }); 202 });
203 }); 203 });
204 204
205 port.on("composer.isPageReady", (message, sender) => 205 port.on("composer.isPageReady", (message, sender) =>
206 { 206 {
207 return readyPages.has(new ext.Page({id: message.pageId})); 207 return readyPages.has(new ext.Page({id: message.pageId}));
208 }); 208 });
209 209
210 port.on("composer.ready", (message, sender) => 210 port.on("composer.ready", (message, sender) =>
211 { 211 {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 263
264 port.on("composer.quoteCSS", (message, sender) => 264 port.on("composer.quoteCSS", (message, sender) =>
265 { 265 {
266 return quoteCSS(message.CSS); 266 return quoteCSS(message.CSS);
267 }); 267 });
268 268
269 ext.pages.onLoading.addListener(page => 269 ext.pages.onLoading.addListener(page =>
270 { 270 {
271 page.sendMessage({type: "composer.content.finished"}); 271 page.sendMessage({type: "composer.content.finished"});
272 }); 272 });
OLDNEW
« no previous file with comments | « ext/background.js ('k') | lib/icon.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld