Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29569634: Noissue - Added flake8-docstrings (codingtools) (Closed)

Created:
Oct. 9, 2017, 1:53 a.m. by Sebastian Noack
Modified:
Oct. 11, 2017, 6:35 p.m.
Visibility:
Public.

Description

Noissue - Added flake8-docstrings (codingtools)

Patch Set 1 #

Total comments: 12

Patch Set 2 : Rebased #

Patch Set 3 : Fixed inconsistent indentation, set basepython for flake8 env #

Patch Set 4 : Don't install patchconv in flake8 venv #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M flake8-eyeo/README.md View 1 chunk +0 lines, -1 line 0 comments Download
M flake8-eyeo/flake8_eyeo.py View 1 1 chunk +2 lines, -4 lines 0 comments Download
R flake8-eyeo/tests/A109.py View 1 chunk +0 lines, -14 lines 0 comments Download
M flake8-eyeo/tox.ini View 1 2 1 chunk +15 lines, -5 lines 0 comments Download
M patchconv/patchconv.py View 1 chunk +1 line, -0 lines 0 comments Download
M patchconv/tox.ini View 1 2 3 1 chunk +12 lines, -3 lines 1 comment Download

Messages

Total messages: 10
Sebastian Noack
https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/flake8_eyeo.py File flake8-eyeo/flake8_eyeo.py (right): https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/flake8_eyeo.py#newcode402 flake8-eyeo/flake8_eyeo.py:402: pass # Ignore multiline strings These are checked by ...
Oct. 9, 2017, 2:08 a.m. (2017-10-09 02:08:59 UTC) #1
Vasily Kuznetsov
https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini File flake8-eyeo/tox.ini (right): https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini#newcode14 flake8-eyeo/tox.ini:14: [testenv:flake8] On 2017/10/09 02:08:58, Sebastian Noack wrote: > This ...
Oct. 9, 2017, 9:16 p.m. (2017-10-09 21:16:15 UTC) #2
tlucas
https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini File flake8-eyeo/tox.ini (right): https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini#newcode2 flake8-eyeo/tox.ini:2: envlist = py{27,35,36}-flake8{2,3},flake8 In case you decide to stick ...
Oct. 9, 2017, 11:39 p.m. (2017-10-09 23:39:39 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini File flake8-eyeo/tox.ini (right): https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini#newcode2 flake8-eyeo/tox.ini:2: envlist = py{27,35,36}-flake8{2,3},flake8 On 2017/10/09 23:39:38, tlucas wrote: > ...
Oct. 10, 2017, 5:34 a.m. (2017-10-10 05:34:30 UTC) #4
tlucas
On 2017/10/10 05:34:30, Sebastian Noack wrote: > https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini > File flake8-eyeo/tox.ini (right): > > https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini#newcode2 ...
Oct. 10, 2017, 8:49 a.m. (2017-10-10 08:49:59 UTC) #5
Vasily Kuznetsov
On 2017/10/10 05:34:30, Sebastian Noack wrote: > https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini > File flake8-eyeo/tox.ini (right): > > https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini#newcode2 ...
Oct. 10, 2017, 12:58 p.m. (2017-10-10 12:58:16 UTC) #6
Vasily Kuznetsov
https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini File flake8-eyeo/tox.ini (right): https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini#newcode16 flake8-eyeo/tox.ini:16: flake8 Nit: these lines have different indentation level. Not ...
Oct. 10, 2017, 1 p.m. (2017-10-10 13:00:08 UTC) #7
Sebastian Noack
https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini File flake8-eyeo/tox.ini (right): https://codereview.adblockplus.org/29569634/diff/29569635/flake8-eyeo/tox.ini#newcode14 flake8-eyeo/tox.ini:14: [testenv:flake8] On 2017/10/10 12:58:16, Vasily Kuznetsov wrote: > On ...
Oct. 10, 2017, 6:17 p.m. (2017-10-10 18:17:40 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29569634/diff/29573174/patchconv/tox.ini File patchconv/tox.ini (right): https://codereview.adblockplus.org/29569634/diff/29573174/patchconv/tox.ini#newcode17 patchconv/tox.ini:17: skip_install = true Since this environment is only for ...
Oct. 11, 2017, 3:30 a.m. (2017-10-11 03:30:44 UTC) #9
Vasily Kuznetsov
Oct. 11, 2017, 4:25 p.m. (2017-10-11 16:25:47 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld