Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29569649: Issue 4580 - Replace ext.i18n with i18n (Closed)

Created:
Oct. 9, 2017, 5:02 a.m. by Manish Jethani
Modified:
Oct. 10, 2017, 5:29 p.m.
Reviewers:
Sebastian Noack
CC:
kzar, Thomas Greiner
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Related: https://codereview.adblockplus.org/29569659/

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update adblockplusui dependency #

Patch Set 3 : Update adblockplusui dependency again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M dependencies View 1 2 1 chunk +1 line, -1 line 0 comments Download
M desktop-options.js View 6 chunks +8 lines, -8 lines 0 comments Download
M ext/common.js View 1 chunk +0 lines, -1 line 0 comments Download
M ext/popup.js View 1 chunk +0 lines, -5 lines 0 comments Download
M lib/filterComposer.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/filterValidation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/notificationHelper.js View 4 chunks +6 lines, -6 lines 0 comments Download
M lib/utils.js View 2 chunks +3 lines, -3 lines 0 comments Download
M stats.js View 4 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
Oct. 9, 2017, 5:02 a.m. (2017-10-09 05:02:30 UTC) #1
Sebastian Noack
Nice, LGTM! But a more acurrate commit message would be: Noissue - Replace ext.i18n with ...
Oct. 9, 2017, 5:11 a.m. (2017-10-09 05:11:34 UTC) #2
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29569649/diff/29569650/ext/popup.js File ext/popup.js (left): https://codereview.adblockplus.org/29569649/diff/29569650/ext/popup.js#oldcode13 ext/popup.js:13: window.ext.i18n = chrome.i18n; This is no ...
Oct. 9, 2017, 5:12 a.m. (2017-10-09 05:12:53 UTC) #3
Manish Jethani
On 2017/10/09 05:11:34, Sebastian Noack wrote: > Nice, LGTM! Ah, you beat me to it! ...
Oct. 9, 2017, 5:15 a.m. (2017-10-09 05:15:05 UTC) #4
Manish Jethani
This will have to wait until 29569659.
Oct. 9, 2017, 5:16 a.m. (2017-10-09 05:16:37 UTC) #5
Manish Jethani
Patch Set 2: Update adblockplusui dependency
Oct. 10, 2017, 1:01 p.m. (2017-10-10 13:01:51 UTC) #6
Manish Jethani
Patch Set 3: Update adblockplusui dependency again
Oct. 10, 2017, 4:53 p.m. (2017-10-10 16:53:04 UTC) #7
Sebastian Noack
Oct. 10, 2017, 5:16 p.m. (2017-10-10 17:16:12 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld