Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/popup.js

Issue 29569649: Issue 4580 - Replace ext.i18n with i18n (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Oct. 9, 2017, 5:02 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ext/common.js ('k') | lib/filterComposer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/popup.js
===================================================================
--- a/ext/popup.js
+++ b/ext/popup.js
@@ -2,21 +2,16 @@
(function()
{
if (typeof chrome == "undefined" || typeof chrome.extension == "undefined")
window.chrome = browser;
const backgroundPage = chrome.extension.getBackgroundPage();
window.ext = Object.create(backgroundPage.ext);
- // Calling i18n.getMessage from the background page causes Edge to throw an
- // exception.
- // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12793975/
- window.ext.i18n = chrome.i18n;
Manish Jethani 2017/10/09 05:12:53 This is no longer necessary since we're not access
-
// We have to override ext.backgroundPage, because in order
// to send messages the local "chrome" namespace must be used.
window.ext.backgroundPage = {
sendMessage: chrome.runtime.sendMessage,
getWindow()
{
return backgroundPage;
« no previous file with comments | « ext/common.js ('k') | lib/filterComposer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld