Issue 5846 - Add support for greenhouse for jobs on eyeo.com

includes/jobs/header.tmpl

Index: includes/jobs/header.tmpl
===================================================================
--- a/includes/jobs/header.tmpl
+++ b/includes/jobs/header.tmpl
@@ -7,43 +7,47 @@
   <style>
     #tabs-openings .ui-tabs-nav-vertical
     {
       font-size: 16px;
     }
   </style>
 {% endblock %}
 
+{% set GREENHOUSE = 1 %}
+{% set TALENTTRACKER = 2 %}
+{% set EMAIL = 3 %}

[ire, 2017/10/10 08:18:33]

NIT: I found this a bit confusing to understand at first. What is the benefit of
setting these variables up here, instead of just placing them as strings where
they are used? 

e.g. :

("IT System Administrator", "it-system-administrator", "talenttracker", 189)

Then just checking for the string in the footer:

{%- if opening[2] == "talenttracker" -%}

etc.

On initial look, it made me think you were doing something with the numbers
themselves (1, 2, 3).

[juliandoucette, 2017/10/10 10:46:22]

- variable / constant names are more commonly autocompleted (some editors
autocomplete common strings too)
- variable / constant name typos are more commonly identified by intenseness
(some editors spot typos in strings too)
- a single value takes up less memory than multiple 
- a small positive int takes up less memory than a string 

(I'm lazy, mildly dyslexic (brain typo), and I type fast (finger typo) -
autocomplete helps :D)

(I like these optimizations. But they are not necessary.)

(This is a ~classical programming habit and these are ~classical programming
reasons.)

[juliandoucette, 2017/10/10 10:57:12]

@wspee Do you think that this makes a difference to HR/Recruitment?

[ire, 2017/10/10 11:43:52]

We probably don't need the EMAIL constant anymore do we? I don't mind if you
want to keep it for the sake of being explicit

[ire, 2017/10/10 11:43:52]

Okay, I agree with your decision

+
 {% set openings = [
-  ("IT System Administrator", "it-system-administrator", 189),
-  ("Data Engineer", "data-engineer", 194),
-  ("Technical Support Analyst", "technical-support-analyst", 191),
-  ("Filter List Supporter", "filter-list-supporter", 127),
-  ("Whitelist Maintainer", "whitelist-maintainer", 108),
-  ("Flattr Campaign Coordinator (Student Help)", "flattr-campaign-coordinator-student-help", 195),
-  ("Student Help Acceptable Ads Monitoring", "student-help-acceptable-ads-monitoring", 193),
-  ("Student Help Data Protection (m/w)", "student-help-data-protection", 178),
-  ("Speculative Application", "speculative-application", 51),
+  ("IT System Administrator", "it-system-administrator", TALENTTRACKER, 189),
+  ("Data Engineer", "data-engineer", TALENTTRACKER, 194),
+  ("Technical Support Analyst", "technical-support-analyst", TALENTTRACKER, 191),
+  ("Filter List Supporter", "filter-list-supporter", TALENTTRACKER, 127),
+  ("Whitelist Maintainer", "whitelist-maintainer", TALENTTRACKER, 108),
+  ("Flattr Campaign Coordinator (Student Help)", "flattr-campaign-coordinator-student-help", TALENTTRACKER, 195),
+  ("Student Help Acceptable Ads Monitoring", "student-help-acceptable-ads-monitoring", TALENTTRACKER, 193),
+  ("Student Help Data Protection (m/w)", "student-help-data-protection", TALENTTRACKER, 178),
+  ("Speculative Application", "speculative-application", TALENTTRACKER, 51),
 ] %}
 
 {% set opening = openings|find(page.split("/")[-1], attribute=1) %}
 {% set title = (opening or [title])[0] %}
 {% set og_image = "https://eyeo.com/images/eyeo-meta-jobs.png" %}
 
 <header class="page-title">
   <h1>Working at eyeo</h1>
 </header>
 
 <div id="jobs-info" class="content-block">
   <div id="tabs-openings" class="columns-container one-sidebar">
     <div class="column sidebar-left">
       <h3 class="heading centered"><span>Current openings:</span></h3>
 
       <ul class="ui-tabs-nav ui-tabs-nav-vertical">
-        {% for title, file, _ in openings %}
+        {% for title, file, type, id in openings %}
           <li {% if file == page.split("/")[-1] %} class="ui-tabs-active" {% endif %}>
             {{("jobs/" + file)|linkify(class="ui-tabs-anchor")}}
               {{ title }}
               {% if file in german_openings %}
                 <img src="/images/flags/germany.png" alt="German" width="15" height="10">
               {% endif %}
             </a>
           </li>