Issue 5847 - Add prefs.set message handler

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 319 matching lines @@
         Prefs.on(preference, () =>
         {
           sendMessage("pref", preference, Prefs[preference]);
         });
       }
     }
   });
 
   port.on("prefs.set", (message, sender) =>
   {
     if (message.key == "notifications_ignoredcategories")

[Manish Jethani, 2017/10/09 15:16:52]

Um ... what if message.value is undefined? Then it'll get toggled, but that's
not the intention. I think it should be a no-op in that case.

So maybe we should add another check 'typeof message.value == "boolean")'

[kzar, 2017/10/09 15:24:08]

Well I agree that toggling isn't the intention in that situation, but not about
the no-op part. So kinda-Done.

[Manish Jethani, 2017/10/09 15:26:29]

Hmm ... OK, yeah, that's probably better.

-      return NotificationStorage.toggleIgnoreCategory("*", message.value);
+      return NotificationStorage.toggleIgnoreCategory("*", !!message.value);
 
     return Prefs[message.key] = message.value;
   });
 
   port.on("prefs.toggle", (message, sender) =>
   {
     if (message.key == "notifications_ignoredcategories")
       return NotificationStorage.toggleIgnoreCategory("*");
 
     return Prefs[message.key] = !Prefs[message.key];
@@ skipping 85 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);