Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: messageResponder.js

Issue 29570584: Issue 5847 - Add prefs.set message handler (Closed)
Patch Set: Fixed typo Created Oct. 9, 2017, 3:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: messageResponder.js
diff --git a/messageResponder.js b/messageResponder.js
index 47f4b05a9d88c8969531c2aac61c2d9ea0270cc0..453a2c3c944439bc7d5553aaea084195aaba5de0 100644
--- a/messageResponder.js
+++ b/messageResponder.js
@@ -335,6 +335,14 @@
}
});
+ port.on("prefs.set", (message, sender) =>
+ {
+ if (message.key == "notifications_ignoredcategories")
Manish Jethani 2017/10/09 15:16:52 Um ... what if message.value is undefined? Then it
kzar 2017/10/09 15:24:08 Well I agree that toggling isn't the intention in
Manish Jethani 2017/10/09 15:26:29 Hmm ... OK, yeah, that's probably better.
+ return NotificationStorage.toggleIgnoreCategory("*", message.value);
+
+ return Prefs[message.key] = message.value;
+ });
+
port.on("prefs.toggle", (message, sender) =>
{
if (message.key == "notifications_ignoredcategories")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld