Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(784)

Issue 29570589: Noissue - Adjustments related to copyright text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by diegocarloslima
Modified:
1 month ago
Reviewers:
jens, anton
CC:
René Jeschke, Felix Dahlke
Visibility:
Public.

Description

Noissue - Adjustments related to copyright text

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -3 lines) Patch
M adblockplus/build.py View 1 chunk +15 lines, -0 lines 0 comments Download
M mobile/android/base/resources/drawable/abb_start_pane_button.xml View 1 chunk +17 lines, -0 lines 2 comments Download
M mobile/android/base/resources/layout/abb_custom_prefscreen.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/layout/abb_minimal_widget.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/layout/abb_start_pane.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/layout/abb_start_pane_step_1.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/layout/abb_start_pane_step_2.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/layout/abb_start_pane_step_3.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/values/abb_colors.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/values/abb_dimens.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/xml/preferences_abb_abp.xml View 1 chunk +16 lines, -3 lines 0 comments Download
M mobile/android/base/resources/xml/preferences_abb_abp_acceptable_ads.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/xml/preferences_abb_adblocking.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M mobile/android/base/resources/xml/preferences_abb_more_blocking.xml View 1 chunk +17 lines, -0 lines 0 comments Download
M translations.py View 1 chunk +15 lines, -0 lines 2 comments Download

Messages

Total messages: 8
diegocarloslima
2 months ago (2017-10-09 14:55:14 UTC) #1
anton
https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base/resources/drawable/abb_start_pane_button.xml File mobile/android/base/resources/drawable/abb_start_pane_button.xml (right): https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base/resources/drawable/abb_start_pane_button.xml#newcode3 mobile/android/base/resources/drawable/abb_start_pane_button.xml:3: - This file is part of the Adblock Plus ...
2 months ago (2017-10-10 06:20:58 UTC) #2
jens
https://codereview.adblockplus.org/29570589/diff/29570590/translations.py File translations.py (right): https://codereview.adblockplus.org/29570589/diff/29570590/translations.py#newcode16 translations.py:16: # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. ...
2 months ago (2017-10-10 14:10:39 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base/resources/drawable/abb_start_pane_button.xml File mobile/android/base/resources/drawable/abb_start_pane_button.xml (right): https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base/resources/drawable/abb_start_pane_button.xml#newcode3 mobile/android/base/resources/drawable/abb_start_pane_button.xml:3: - This file is part of the Adblock Plus ...
2 months ago (2017-10-10 14:29:39 UTC) #4
jens
On 2017/10/10 14:29:39, diegocarloslima wrote: > https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base/resources/drawable/abb_start_pane_button.xml > File mobile/android/base/resources/drawable/abb_start_pane_button.xml (right): > > https://codereview.adblockplus.org/29570589/diff/29570590/mobile/android/base/resources/drawable/abb_start_pane_button.xml#newcode3 > ...
2 months ago (2017-10-11 08:01:22 UTC) #5
anton
On 2017/10/10 14:10:39, jens wrote: > https://codereview.adblockplus.org/29570589/diff/29570590/translations.py > File translations.py (right): > > https://codereview.adblockplus.org/29570589/diff/29570590/translations.py#newcode16 > ...
2 months ago (2017-10-12 05:47:40 UTC) #6
anton
On 2017/10/09 14:55:14, diegocarloslima wrote: LGTM
2 months ago (2017-10-12 05:48:37 UTC) #7
jens
2 months ago (2017-10-12 07:54:14 UTC) #8
On 2017/10/12 05:48:37, anton wrote:
> On 2017/10/09 14:55:14, diegocarloslima wrote:
> 
> LGTM

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5