ext/popup.js - Issue 29570614: Issue 5028 - Use browser namespace

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: ext/popup.js

Issue 29570614: Issue 5028 - Use browser namespace (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Created Oct. 9, 2017, 3:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 "use strict";	1 "use strict";

2	2

3 (function()	3 (function()

4 {	4 {

5 if (typeof chrome == "undefined" \|\| typeof chrome.extension == "undefined")	5 const backgroundPage = browser.extension.getBackgroundPage();
Manish Jethani 2017/10/09 15:49:41 This is redundant since it's already done in ext/c This is redundant since it's already done in ext/common.js
6 window.chrome = browser;

7 const backgroundPage = chrome.extension.getBackgroundPage();

8 window.ext = Object.create(backgroundPage.ext);	6 window.ext = Object.create(backgroundPage.ext);

9	7

10 // We have to override ext.backgroundPage, because in order	8 // We have to override ext.backgroundPage, because in order

11 // to send messages the local "chrome" namespace must be used.	9 // to send messages the local "browser" namespace must be used.

12 window.ext.backgroundPage = {	10 window.ext.backgroundPage = {

13 sendMessage: chrome.runtime.sendMessage,	11 sendMessage: browser.runtime.sendMessage,

14	12

15 getWindow()	13 getWindow()

16 {	14 {

17 return backgroundPage;	15 return backgroundPage;

18 }	16 }

19 };	17 };

20 }());	18 }());

OLD	NEW