Issue 5028 - Use browser namespace

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 194 matching lines @@
         // We use the highest priority to prevent the notification
         // from closing automatically.
         priority: 2
       });
     }
     else if ("Notification" in window && activeNotification.type != "question")
     {
       if (linkCount > 0)
       {
         message += " " + browser.i18n.getMessage(
-          "notification_without_buttons");

[kzar, 2017/10/16 10:35:51]

Nit: IMO it looks weird having the indentation like this without putting the
closing parenthesis on the next line. (Same below.)

[Manish Jethani, 2017/10/16 12:17:35]

Done.

+          "notification_without_buttons"
+        );
       }
 
       let widget = new Notification(
         title,
         {
           lang: Utils.appLocale,
           dir: Utils.readingDirection,
           body: message,
           icon: iconUrl
         }
       );
 
       widget.addEventListener("click", openNotificationLinks);
       widget.addEventListener("close", notificationClosed);
     }
     else
     {
       message = title + "\n" + message;
       if (linkCount > 0)
       {
         message += "\n\n" + browser.i18n.getMessage(
-          "notification_with_buttons");
+          "notification_with_buttons"
+        );
       }
 
       let approved = confirm(message);
       if (activeNotification.type == "question")
         notificationButtonClick(approved ? 0 : 1);
       else if (approved)
         openNotificationLinks();
     }
   }
   prepareNotificationIconAndPopup();
@@ skipping 33 matching lines @@
   let methods = displayMethods[notificationType] || defaultDisplayMethods;
   return methods.includes(method);
 };
 
 ext.pages.onLoading.addListener(page =>
 {
   NotificationStorage.showNext(stringifyURL(page.url));
 });
 
 NotificationStorage.addShowListener(showNotification);