Noissue - Lint adjustments

mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 186 matching lines @@
     {
       Log.e(TAG, "Failed to parse json to request list with error: " + e.getMessage(), e);
     }
     return requestList;
   }
 
   private static void storeStringPref(String key, String value)
   {
     final SharedPreferences.Editor editor = sharedPrefs.edit();
     editor.putString(key, value);
-    editor.apply();

[anton, 2017/10/10 12:19:43]

this seems to be not lint change: apply returns immediately but commit blocks
the thread until it's actually written.
I'd suggest it to be done in separate code review as it changes app logics (not
just code style for lint).

[diegocarloslima, 2017/10/10 14:54:18]

Actually this is a lint warning, but I agree with you, since this is not just a
coding style or best practice and is more prone to bugs, it would make more
sense to treat it separately

[anton, 2017/10/12 05:50:17]

okay, waiting for the next patch set to LGTM it

+    editor.commit();
   }
 
   public static boolean getBooleanFromJsObject(final NativeJSObject obj, final String name,
       final boolean defaultValue)
   {
     try
     {
       return obj.getBoolean(name);
     }
     catch (final Exception e)
@@ skipping 225 matching lines @@
       {
         this.invokeSuccessCallback(jsObject);
       }
       else
       {
         this.invokeFailureCallback(jsObject);
       }
     }
   }
 
   private static class AddOnEventListener implements BundleEventListener

[anton, 2017/10/10 12:19:42]

is it lint change too? seems to be not.

[diegocarloslima, 2017/10/10 14:54:18]

Yeah, actually this was a deprecation warning in

EventDispatcher.getInstance().registerGeckoThreadListener(ADD_ON_EVENT_LISTENER,
ON_FILTERS_LOAD_EVENT, ON_FILTERS_SAVE_EVENT);

which uses this deprecated method
https://hg.adblockplus.org/adblockbrowser/file/7018960f20ac/mobile/android/ge...

[anton, 2017/10/12 05:50:17]

Acknowledged.

   {
     @Override
     public void handleMessage(String event, GeckoBundle message, EventCallback callback)
     {
       if (ON_FILTERS_LOAD_EVENT.equals(event))
       {
         // The filters have been loaded by the extension. Given that, we can send all pending requests
         filtersLoaded = true;
         sendPendingRequests();
       }
       else if (ON_FILTERS_SAVE_EVENT.equals(event))
       {
         // All changes have been saved by the extension. That way, we can clear our list of
         // pending requests
         // See https://issues.adblockplus.org/ticket/2853
         clearPendingRequests();
       }
     }
   }
 }