Delta Between Two Patch Sets: includes/product-topics-accordion.tmpl
Issue 29572657:
Issue 5787 - Add Topics Accordion to Article Template on help.eyeo.com (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set:
Created Oct. 10, 2017, 12:27 p.m.
Right Patch Set: Addressed final NITs
Created Oct. 11, 2017, 5:01 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
static/js/main.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <dl id="product-topics-accordion" class="accordion"> | 1 <dl id="product-topics-accordion" class="accordion"> |
| 2 {% for category in product.help_categories %} | 2 {% for category in product.help_categories %} |
| 3 {% set articles = get_pages_metadata({ "product_id": product_id, "template": " article", "category": category.name }) %} | 3 {% set articles = get_pages_metadata({ "product_id": product_id, "template": "article", "category": category.name }) %} |
|
juliandoucette
2017/10/11 15:09:48
NIT: I think we indent after for
ire
2017/10/11 17:01:41
Done.
| |
| 4 {% if articles %} | 4 {% if articles %} |
| 5 <dt role="heading" aria-level="3" class="accordion-heading"> | 5 <dt role="heading" aria-level="3" class="accordion-heading"> |
|
juliandoucette
2017/10/11 15:09:48
NIT: I think we indent after if
ire
2017/10/11 17:01:41
Done.
| |
| 6 <button aria-expanded="true" aria-controls="sect-{{ category.slug }}" id="he ading-{{ category.slug }}" class="accordion-toggle-button"> | 6 <button aria-expanded="true" aria-controls="sect-{{ category.slug }}" id ="heading-{{ category.slug }}" class="accordion-toggle-button"> |
| 7 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-icon-s econdary.svg 2x" alt="{{ "Toggle Section" | translate("accordion-toggle-icon", " Image alt text") }}"> | 7 <img src="/img/png/arrow-icon-secondary.png" srcset="/img/svg/arrow-ic on-secondary.svg 2x" alt="{{ "Toggle arrow" | translate("accordion-toggle-icon", "Image alt text") }}"> |
|
juliandoucette
2017/10/11 15:09:48
NIT/Suggest: "Toggle arrow"? - more visually desc
ire
2017/10/11 17:01:41
Done.
| |
| 8 {{ category.name | translate( category.slug + "-category-title", "Category title") }} | 8 {{ category.name | translate( category.slug + "-category-title", "Cate gory title") }} |
| 9 </button> | 9 </button> |
| 10 </dt> | 10 </dt> |
| 11 <dd role="region" aria-labelledby="heading-{{ category.slug }}" id="sect-{{ ca tegory.slug }}" class="accordion-body"> | 11 <dd role="region" aria-labelledby="heading-{{ category.slug }}" id="sect-{ { category.slug }}" class="accordion-body"> |
| 12 <ul class="underlined-list"> | 12 <ul class="underlined-list"> |
| 13 {% for article in articles %} | 13 {% for article in articles %} |
| 14 <li> | 14 <li> |
| 15 <a href="{{ article["page"] }}"> | 15 <a href="{{ article["page"] }}"> |
| 16 {{ article.title | translate( get_page_name( article["page"]) + "-titl e", "Article title") }} | 16 {{ article.title | translate( get_page_name( article["page"]) + "- title", "Article title") }} |
| 17 </a> | 17 </a> |
| 18 </li> | 18 </li> |
| 19 {% endfor %} | 19 {% endfor %} |
| 20 </ul> | 20 </ul> |
| 21 </dd> | 21 </dd> |
| 22 {% endif %} | 22 {% endif %} |
| 23 {% endfor %} | 23 {% endfor %} |
| 24 </dl> | 24 </dl> |
| LEFT | RIGHT |
« no previous file
|
static/js/main.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
