Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: build.py

Issue 29572692: Issue 5845 - Renaming gecko-webext to gecko (Closed)
Patch Set: Removed another webext occurrence Created Oct. 11, 2017, 11:36 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | packagerChrome.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.py
diff --git a/build.py b/build.py
index 0ecab321b8b9f423f0b69d1cb8606a81b587203c..b2e657c6a9c5fa05837f871fae5851472e7c1de8 100644
--- a/build.py
+++ b/build.py
@@ -11,7 +11,7 @@ from getopt import getopt, GetoptError
from StringIO import StringIO
from zipfile import ZipFile
-knownTypes = ('gecko-webext', 'chrome', 'generic', 'edge')
+knownTypes = ('gecko', 'chrome', 'generic', 'edge')
class Command(object):
@@ -179,7 +179,7 @@ def runBuild(baseDir, scriptName, opts, args, type):
for option, value in opts:
if option in {'-b', '--build'}:
kwargs['buildNum'] = value
- if type != 'gecko-webext' and not kwargs['buildNum'].isdigit():
+ if type != 'gecko' and not kwargs['buildNum'].isdigit():
raise TypeError('Build number must be numerical')
elif option in {'-k', '--key'}:
kwargs['keyFile'] = value
@@ -188,7 +188,7 @@ def runBuild(baseDir, scriptName, opts, args, type):
if len(args) > 0:
kwargs['outFile'] = args[0]
- if type in {'chrome', 'gecko-webext'}:
+ if type in {'chrome', 'gecko'}:
import buildtools.packagerChrome as packager
elif type == 'edge':
import buildtools.packagerEdge as packager
@@ -389,12 +389,12 @@ with addCommand(runBuild, 'build') as command:
command.addOption('Use given build number (if omitted the build number will be retrieved from Mercurial)', short='b', long='build', value='num')
command.addOption('File containing private key and certificates required to sign the package', short='k', long='key', value='file', types=('chrome',))
command.addOption('Create a release build', short='r', long='release')
- command.supportedTypes = ('gecko-webext', 'chrome', 'edge')
+ command.supportedTypes = ('gecko', 'chrome', 'edge')
with addCommand(createDevEnv, 'devenv') as command:
command.shortDescription = 'Set up a development environment'
command.description = 'Will set up or update the devenv folder as an unpacked extension folder for development.'
- command.supportedTypes = ('gecko-webext', 'chrome')
+ command.supportedTypes = ('gecko', 'chrome')
with addCommand(setupTranslations, 'setuptrans') as command:
command.shortDescription = 'Sets up translation languages'
« no previous file with comments | « no previous file | packagerChrome.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld