Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: desktop-options.js

Issue 29572786: Issue 5842 - use specialization instead of translating the language (Closed)
Patch Set: Created Oct. 10, 2017, 5:22 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | locale/en-US/desktop-options.json » ('j') | locale/en-US/desktop-options.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: desktop-options.js
===================================================================
--- a/desktop-options.js
+++ b/desktop-options.js
@@ -88,6 +88,8 @@
Collection.prototype._getItemTitle = function(item, i)
{
+ if (this.details[i].useSpecialization && item.specialization)
+ return item.specialization;
if (this.details[i].useOriginalTitle && item.originalTitle)
return item.originalTitle;
return item.title || item.url || item.text;
@@ -347,13 +349,15 @@
collections.langs = new Collection([
{
id: "blocking-languages-table",
- emptyTexts: ["options_language_empty"]
+ emptyTexts: ["options_language_empty"],
+ useSpecialization: true
}
]);
collections.allLangs = new Collection([
{
id: "all-lang-table-add",
- emptyTexts: ["options_dialog_language_other_empty"]
+ emptyTexts: ["options_dialog_language_other_empty"],
+ useSpecialization: true
}
]);
collections.more = new Collection([
@@ -497,6 +501,7 @@
disabled: true,
downloadStatus: null,
homepage: null,
+ specialization: element.getAttribute("specialization"),
originalTitle: element.getAttribute("title"),
recommended: type,
url: element.getAttribute("url")
« no previous file with comments | « no previous file | locale/en-US/desktop-options.json » ('j') | locale/en-US/desktop-options.json » ('J')

Powered by Google App Engine
This is Rietveld