Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29572820: Issue 5727 - Implement non-embedded homepage video on abp.org (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Updated levels Created Oct. 12, 2017, 7:44 p.m.
Right Patch Set: Addressed NITs Created Oct. 16, 2017, 8:27 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/index.tmpl ('k') | static/css/index-mobile.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #content h1, #content h2 1 #content h1, #content h2
2 { 2 {
3 font-size: 16px; 3 font-size: 16px;
4 } 4 }
5 5
6 #content .sprite 6 #content .sprite
7 { 7 {
8 background-image: url(../img/sprite-index.png); 8 background-image: url(../img/sprite-index.png);
9 } 9 }
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 { 91 {
92 position: relative; 92 position: relative;
93 box-sizing: border-box; 93 box-sizing: border-box;
94 width: 100%; 94 width: 100%;
95 max-width: 520px; 95 max-width: 520px;
96 } 96 }
97 97
98 #video 98 #video
99 { 99 {
100 display: block; 100 display: block;
101 position: relative; 101 position: relative;
juliandoucette 2017/10/13 12:20:11 NIT: I don't think that this does anything?
ire 2017/10/16 08:28:01 The #video-play icon is positioned absolutely in t
juliandoucette 2017/10/16 12:22:01 Acknowledged.
102 width: 100%; 102 width: 100%;
juliandoucette 2017/10/13 12:20:11 NIT: I don't think that this does anything?
ire 2017/10/16 08:28:00 It keeps the <iframe id="video"> from extending ou
juliandoucette 2017/10/16 12:22:01 Acknowledged.
103 } 103 }
104 104
105 #video-thumbnail 105 #video-thumbnail
106 { 106 {
107 width: 100%; 107 width: 100%;
108 transition: opacity 0.8s; 108 transition: opacity 0.8s;
109 } 109 }
110 110
111 .no-js #video-thumbnail, 111 .no-js #video-thumbnail,
112 .show-disclaimer #video-thumbnail 112 .show-disclaimer #video-thumbnail
113 { 113 {
114 opacity: 0.2; 114 opacity: 0.2;
115 } 115 }
116 116
117 #video-disclaimer 117 #video-disclaimer
118 { 118 {
119 visibility: hidden; 119 visibility: hidden;
120 opacity: 0; 120 opacity: 0;
121 position: absolute; 121 position: absolute;
122 bottom: 0; 122 bottom: 0;
123 left: 0; 123 left: 0;
124 box-sizing: border-box;
juliandoucette 2017/10/13 12:20:11 NIT: I don't think that this does anything?
ire 2017/10/16 08:28:00 Done.
125 margin: 20px; 124 margin: 20px;
126 background-color: #fff; 125 background-color: #fff;
127 font-size: 0.9em; 126 font-size: 0.9em;
128 text-align: center; 127 text-align: center;
129 transition: opacity 0.8s; 128 transition: opacity 0.8s;
130 } 129 }
131 130
132 .no-js #video-disclaimer, 131 .no-js #video-disclaimer,
133 .show-disclaimer #video-disclaimer 132 .show-disclaimer #video-disclaimer
134 { 133 {
135 visibility: visible; 134 visibility: visible;
136 opacity: 1; 135 opacity: 1;
137 } 136 }
138 137
139 #video-play 138 #video-play
juliandoucette 2017/10/13 12:20:11 NIT/Suggest: Move this up a little bit on desktop
ire 2017/10/16 08:28:00 Done.
140 { 139 {
141 position: absolute; 140 position: absolute;
142 top: 50%; 141 top: 50%;
143 left: 50%; 142 left: 50%;
144 width: 100px; 143 width: 80px;
juliandoucette 2017/10/13 12:20:11 NIT: I think that this is too big?
ire 2017/10/16 08:28:00 I'll change it to 80px so it'll be the same on mob
ire 2017/10/16 08:28:00 Done.
145 margin-top: -50px; 144 margin-top: -40px;
146 margin-left: -50px; 145 margin-left: -40px;
146 }
147
148 .no-js #video-play,
149 .show-disclaimer #video-play
150 {
151 margin-top: -60px;
147 } 152 }
148 153
149 html[lang^="zh_"] #content.maxthon #maxthon-instruction 154 html[lang^="zh_"] #content.maxthon #maxthon-instruction
150 { 155 {
151 display: inline-block; 156 display: inline-block;
152 padding: 0px; 157 padding: 0px;
153 } 158 }
154 159
155 #content.maxthon #feature-maxthon 160 #content.maxthon #feature-maxthon
156 { 161 {
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 line-height: 1.4; 762 line-height: 1.4;
758 color: #000; 763 color: #000;
759 background-color: #fff; 764 background-color: #fff;
760 border: 2px solid #a1a1a1; 765 border: 2px solid #a1a1a1;
761 } 766 }
762 767
763 #ready-for-windows-notice 768 #ready-for-windows-notice
764 { 769 {
765 margin-bottom: 30px; 770 margin-bottom: 30px;
766 } 771 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld