Side by Side Diff: desktop-options.html
Issue 29573041:
Issue 5850 - Social media links are broken (Closed)
Patch Set:
Created Oct. 10, 2017, 8:12 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 302 <li id="visit-forum" class="i18n_options_report_forum"></li> | 302 <li id="visit-forum" class="i18n_options_report_forum"></li> |
| 303 </ul> | 303 </ul> |
| 304 </section> | 304 </section> |
| 305 <section class="cols"> | 305 <section class="cols"> |
| 306 <header> | 306 <header> |
| 307 <h2 class="i18n_options_social_title"></h2> | 307 <h2 class="i18n_options_social_title"></h2> |
| 308 <p class="i18n_options_social_description"></p> | 308 <p class="i18n_options_social_description"></p> |
| 309 </header> | 309 </header> |
| 310 <div id="social"> | 310 <div id="social"> |
| 311 <ul id="social-general"> | 311 <ul id="social-general"> |
| 312 <li><a id="twitter">Twitter</a></li> | 312 <li><a id="twitter" target="_blank">Twitter</a></li> |
|
saroyanm
2017/10/10 20:15:10
I decided to use target="_blank" instead of target
ire
2017/10/11 09:18:34
Ack. I think this was the right decision.
| |
| 313 <li><a id="facebook">Facebook</a></li> | 313 <li><a id="facebook" target="_blank">Facebook</a></li> |
| 314 <li><a id="google-plus">Google Plus</a></li> | 314 <li><a id="google-plus" target="_blank">Google Plus</a></li> |
| 315 </ul> | 315 </ul> |
| 316 <ul id="social-chinese"> | 316 <ul id="social-chinese"> |
| 317 <li><a id="weibo">Weibo</a></li> | 317 <li><a id="weibo" target="_blank">Weibo</a></li> |
| 318 </ul> | 318 </ul> |
| 319 <p> | 319 <p> |
| 320 <strong> | 320 <strong> |
| 321 <span class="i18n_options_email"></span> | 321 <span class="i18n_options_email"></span> |
| 322 <a href="mailto:support@adblockplus.org">support@adblockplus.org </a> | 322 <a href="mailto:support@adblockplus.org">support@adblockplus.org </a> |
| 323 </strong> | 323 </strong> |
| 324 </p> | 324 </p> |
| 325 </div> | 325 </div> |
| 326 </section> | 326 </section> |
| 327 </div> | 327 </div> |
| (...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 397 </div> | 397 </div> |
| 398 <!-- Notification --> | 398 <!-- Notification --> |
| 399 <div id="notification" aria-hidden="true" aria-live="polite"> | 399 <div id="notification" aria-hidden="true" aria-live="polite"> |
| 400 <strong id="notification-text"></strong> | 400 <strong id="notification-text"></strong> |
| 401 <button id="hide-notification" data-action="hide-notification"> | 401 <button id="hide-notification" data-action="hide-notification"> |
| 402 <span class="i18n_options_notification_hide sr-only"></span> | 402 <span class="i18n_options_notification_hide sr-only"></span> |
| 403 </button> | 403 </button> |
| 404 </div> | 404 </div> |
| 405 </body> | 405 </body> |
| 406 </html> | 406 </html> |
| OLD | NEW |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
