Issue 5147 - Invalidate wrapper on delete

compiled/bindings/generator.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 366 matching lines @@
       {
         var result = function(pointer)
         {
           this._pointer = pointer;
         };
         var proto = (superclass ? superclass.prototype : null);
         result.prototype = Object.create(proto, Object.getOwnPropertyDescriptors(props));
         result.prototype.delete = function()
         {
           Module._ReleaseRef(this._pointer + ref_counted_offset);
-          this._pointer = 0xdeadbeef;

[Wladimir Palant, 2017/10/11 07:45:51]

This is unnecessary, you are overwriting the property below.

           Object.defineProperty(this, "_pointer", {
             get: function() {
-              throw new Error("Deleted object"); return 0xdeadbeef;

[Wladimir Palant, 2017/10/11 07:45:51]

return after throw is dead code.

Nit: "Attemt to use a deleted object" might be a better error message.

+              throw new Error("Attempt to use deleted object");
             },
           });
         };
         return result;
       }
     )");
   }
 
   void printClass(const ClassInfo& cls)
   {
@@ skipping 81 matching lines @@
 
 void printBindings()
 {
   bindings_internal::printHelpers();
 
   for (const auto& cls : classes)
     bindings_internal::printClass(cls);
   for (const auto& cls : classes)
     bindings_internal::printClassMapping(cls);
 }