polyfill.js - Issue 29573083: Issue 5028 - Use browser namespace

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: polyfill.js

Issue 29573083: Issue 5028 - Use browser namespace (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/

Patch Set: Created Oct. 10, 2017, 10:24 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 /*

	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

	3 * Copyright (C) 2006-present eyeo GmbH

	4 *

	5 * Adblock Plus is free software: you can redistribute it and/or modify

	6 * it under the terms of the GNU General Public License version 3 as

	7 * published by the Free Software Foundation.

	8 *

	9 * Adblock Plus is distributed in the hope that it will be useful,

	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

	11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	12 * GNU General Public License for more details.

	13 *

	14 * You should have received a copy of the GNU General Public License

	15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

	16 */

	17

	18 "use strict";

	19

	20 if (typeof browser == "undefined")
	Sebastian Noack 2017/10/10 23:23:08 This check seems unnecessary. This script is only This check seems unnecessary. This script is only included when running the standalone test server within adblockplusui. Manish Jethani 2017/10/11 11:29:06 But if the developer is testing on Chrome, the bro Show quoted text On 2017/10/10 23:23:08, Sebastian Noack wrote: > This check seems unnecessary. This script is only included when running the > standalone test server within adblockplusui. But if the developer is testing on Chrome, the browser object won't be available and consequently they won't be able to test, right? Sebastian Noack 2017/10/13 02:48:17 The browser object will never be available here, a Show quoted text On 2017/10/11 11:29:06, Manish Jethani wrote: > On 2017/10/10 23:23:08, Sebastian Noack wrote: > > This check seems unnecessary. This script is only included when running the > > standalone test server within adblockplusui. > > But if the developer is testing on Chrome, the browser object won't be available > and consequently they won't be able to test, right? The browser object will never be available here, as this code doesn't run in the context of an extension, but in the context of a web page, when testing adblockplusui standalone, which is the only case in which this script runs. Manish Jethani 2017/10/13 05:00:34 Ah, you're right. Done. Show quoted text On 2017/10/13 02:48:17, Sebastian Noack wrote: > On 2017/10/11 11:29:06, Manish Jethani wrote: > > On 2017/10/10 23:23:08, Sebastian Noack wrote: > > > This check seems unnecessary. This script is only included when running the > > > standalone test server within adblockplusui. > > > > But if the developer is testing on Chrome, the browser object won't be > available > > and consequently they won't be able to test, right? > > The browser object will never be available here, as this code doesn't run in the > context of an extension, but in the context of a web page, when testing > adblockplusui standalone, which is the only case in which this script runs. Ah, you're right. Done.
	21 window.browser = {};

OLD	NEW

« ext/common.js ('K') | « mobile-options.js ('k') | no next file » | no next file with comments »