Issue 5028 - Use browser namespace

mobile-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /* globals getDocLink */
 
 "use strict";
 
 {
-  const {getMessage} = chrome.i18n;
+  const {getMessage} = browser.i18n;
 
   const dialogSubscribe = "subscribe";
   const idAcceptableAds = "acceptableAds";
   const idRecommended = "subscriptions-recommended";
   let whitelistFilter = null;
   let promisedAcceptableAdsUrl = getAcceptableAdsUrl();
 
   /* Utility functions */
 
   function get(selector, origin)
@@ skipping 35 matching lines @@
     parent.appendChild(element);
     return element;
   }
 
   /* Extension interactions */
 
   function getInstalled()
   {
     return new Promise((resolve, reject) =>
     {
       chrome.runtime.sendMessage(

[saroyanm, 2017/10/17 11:09:52]

We still use chrome.runtime.sendMessag in current file, same applies to all
other instances in current file.

[Manish Jethani, 2017/10/17 11:35:34]

Done.

         {type: "subscriptions.get", downloadable: true},
         resolve
       );
     });
   }
 
   function getAcceptableAdsUrl()
   {
     return new Promise((resolve, reject) =>
     {
@@ skipping 350 matching lines @@
   get("#dialog-subscribe [name='title']").setAttribute(
     "placeholder",
     getMessage("mops_subscribe_title")
   );
 
   get("#dialog-subscribe [name='url']").setAttribute(
     "placeholder",
     getMessage("mops_subscribe_url")
   );
 }