Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: devtools-panel.js

Issue 29573083: Issue 5028 - Use browser namespace (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/
Left Patch Set: Rebase Created Oct. 16, 2017, 9:33 p.m.
Right Patch Set: Add polyfill.js to README.md Created Oct. 17, 2017, 12:35 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « devtools-panel.html ('k') | ext/common.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 let lastFilterQuery = null; 20 let lastFilterQuery = null;
21 21
22 chrome.runtime.sendMessage({type: "types.get"}, 22 browser.runtime.sendMessage({type: "types.get"},
saroyanm 2017/10/17 11:09:51 There are still couple of chrome.runtime.sendMessa
Manish Jethani 2017/10/17 11:35:33 Really sorry about this. Done.
23 (filterTypes) => 23 (filterTypes) =>
24 { 24 {
25 let filterTypesElem = document.getElementById("filter-type"); 25 let filterTypesElem = document.getElementById("filter-type");
26 let filterStyleElem = document.createElement("style"); 26 let filterStyleElem = document.createElement("style");
27 for (let type of filterTypes) 27 for (let type of filterTypes)
28 { 28 {
29 filterStyleElem.innerHTML += 29 filterStyleElem.innerHTML +=
30 `#items[data-filter-type=${type}] tr:not([data-type=${type}])` + 30 `#items[data-filter-type=${type}] tr:not([data-type=${type}])` +
31 "{display: none;}"; 31 "{display: none;}";
32 let optionNode = document.createElement("option"); 32 let optionNode = document.createElement("option");
(...skipping 27 matching lines...) Expand all
60 60
61 function createActionButton(action, label, filter) 61 function createActionButton(action, label, filter)
62 { 62 {
63 let button = document.createElement("span"); 63 let button = document.createElement("span");
64 64
65 button.textContent = label; 65 button.textContent = label;
66 button.classList.add("action"); 66 button.classList.add("action");
67 67
68 button.addEventListener("click", () => 68 button.addEventListener("click", () =>
69 { 69 {
70 chrome.runtime.sendMessage({ 70 browser.runtime.sendMessage({
71 type: "filters." + action, 71 type: "filters." + action,
72 text: filter 72 text: filter
73 }); 73 });
74 }, false); 74 }, false);
75 75
76 return button; 76 return button;
77 } 77 }
78 78
79 function createRecord(request, filter, template) 79 function createRecord(request, filter, template)
80 { 80 {
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 break; 250 break;
251 } 251 }
252 }); 252 });
253 253
254 // Since Chrome 54 the themeName is accessible, for earlier versions we must 254 // Since Chrome 54 the themeName is accessible, for earlier versions we must
255 // assume the default theme is being used. 255 // assume the default theme is being used.
256 // https://bugs.chromium.org/p/chromium/issues/detail?id=608869 256 // https://bugs.chromium.org/p/chromium/issues/detail?id=608869
257 let theme = browser.devtools.panels.themeName || "default"; 257 let theme = browser.devtools.panels.themeName || "default";
258 document.body.classList.add(theme); 258 document.body.classList.add(theme);
259 }, false); 259 }, false);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld