Issue 5028 - Use browser namespace

mobile-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 58 matching lines @@
     parent.appendChild(element);
     return element;
   }
 
   /* Extension interactions */
 
   function getInstalled()
   {
     return new Promise((resolve, reject) =>
     {
-      chrome.runtime.sendMessage(

[saroyanm, 2017/10/17 11:09:52]

We still use chrome.runtime.sendMessag in current file, same applies to all
other instances in current file.

[Manish Jethani, 2017/10/17 11:35:34]

Done.

+      browser.runtime.sendMessage(
         {type: "subscriptions.get", downloadable: true},
         resolve
       );
     });
   }
 
   function getAcceptableAdsUrl()
   {
     return new Promise((resolve, reject) =>
     {
-      chrome.runtime.sendMessage(
+      browser.runtime.sendMessage(
         {type: "prefs.get", key: "subscriptions_exceptionsurl"},
         resolve
       );
     });
   }
 
   function getRecommendedAds()
   {
     return fetch("subscriptions.xml")
       .then((response) => response.text())
       .then((text) =>
       {
         let doc = new DOMParser().parseFromString(text, "application/xml");
         let elements = Array.from(doc.getElementsByTagName("subscription"));
 
         return elements
           .filter((element) => element.getAttribute("type") == "ads")
           .map((element) =>
           {
             return {
               title: element.getAttribute("title"),
               url: element.getAttribute("url")
             };
           });
       });
   }
 
   function installSubscription(url, title)
   {
-    chrome.runtime.sendMessage({type: "subscriptions.add", url, title});
+    browser.runtime.sendMessage({type: "subscriptions.add", url, title});
   }
 
   function uninstallSubscription(url)
   {
-    chrome.runtime.sendMessage({type: "subscriptions.remove", url});
+    browser.runtime.sendMessage({type: "subscriptions.remove", url});
   }
 
   /* Actions */
 
   function setFilter({disabled, text}, action)
   {
     if (!whitelistFilter || text != whitelistFilter)
       return;
 
     get("#enabled").checked = (action == "remove" || disabled);
@@ skipping 147 matching lines @@
         uninstallSubscription(acceptableAdsUrl);
       }
     });
   }
   document.addEventListener("change", onChange);
 
   function toggleWhitelistFilter(toggle)
   {
     if (whitelistFilter)
     {
-      chrome.runtime.sendMessage(
+      browser.runtime.sendMessage(
         {
           type: (toggle.checked) ? "filters.remove" : "filters.add",
           text: whitelistFilter
         },
         (errors) =>
         {
           if (errors.length < 1)
             return;
 
           console.error(errors);
@@ skipping 102 matching lines @@
             // not installed so we shouldn't add those by accident
             setSubscription(subscription, "update");
             break;
         }
         break;
       }
     }
   }
   ext.onMessage.addListener(onMessage);
 
-  chrome.runtime.sendMessage({
+  browser.runtime.sendMessage({
     type: "app.listen",
     filter: ["addSubscription", "showPageOptions"]
   });
 
-  chrome.runtime.sendMessage({
+  browser.runtime.sendMessage({
     type: "filters.listen",
     filter: ["added", "removed"]
   });
 
-  chrome.runtime.sendMessage({
+  browser.runtime.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "removed", "title"]
   });
 
   /* Initialization */
 
   populateLists();
 
   getDocLink("acceptable_ads", (link) =>
   {
     get("#acceptableAds-more").href = link;
   });
 
   get("#dialog-subscribe [name='title']").setAttribute(
     "placeholder",
     getMessage("mops_subscribe_title")
   );
 
   get("#dialog-subscribe [name='url']").setAttribute(
     "placeholder",
     getMessage("mops_subscribe_url")
   );
 }